vtkF3DAssimpImporter: Add CanReadFile support#2831
Merged
mwestphal merged 9 commits intof3d-app:masterfrom Feb 5, 2026
Merged
Conversation
50e8851 to
374f596
Compare
c16f646 to
b03cfc4
Compare
b03cfc4 to
9c2540e
Compare
Member
Author
|
\ci full |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2831 +/- ##
========================================
Coverage 96.92% 96.93%
========================================
Files 206 206
Lines 15702 15804 +102
========================================
+ Hits 15219 15319 +100
- Misses 483 485 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Meakk
reviewed
Feb 4, 2026
plugins/assimp/module/Testing/TestF3DAssimpImportCanReadFile.cxx
Outdated
Show resolved
Hide resolved
34 tasks
Meakk
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Note 3mf check is actually a ZIP archive check, this is ok until we support other ZIP based format.
Issue ticket number and link if any
github.com//issues/2493
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.