Skip to content

vtkF3DAssimpImporter: Add CanReadFile support#2831

Merged
mwestphal merged 9 commits intof3d-app:masterfrom
mwestphal:assimp_canreadfile
Feb 5, 2026
Merged

vtkF3DAssimpImporter: Add CanReadFile support#2831
mwestphal merged 9 commits intof3d-app:masterfrom
mwestphal:assimp_canreadfile

Conversation

@mwestphal
Copy link
Member

@mwestphal mwestphal commented Jan 27, 2026

Describe your changes

  • Add CanReadFile(stream, hint) support for fbx, collada, 3mf, off, dxf, x
  • Add tests

Note 3mf check is actually a ZIP archive check, this is ok until we support other ZIP based format.

Issue ticket number and link if any

github.com//issues/2493

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@mwestphal mwestphal marked this pull request as ready for review February 2, 2026 20:22
@mwestphal mwestphal changed the title fbx vtkF3DAssimpImporter: Add CanReadFile support Feb 2, 2026
@mwestphal mwestphal self-assigned this Feb 3, 2026
@mwestphal
Copy link
Member Author

\ci full

@mwestphal mwestphal requested a review from Meakk February 3, 2026 21:10
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.93%. Comparing base (179e6bb) to head (25a304f).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2831    +/-   ##
========================================
  Coverage   96.92%   96.93%            
========================================
  Files         206      206            
  Lines       15702    15804   +102     
========================================
+ Hits        15219    15319   +100     
- Misses        483      485     +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@f3d-app f3d-app deleted a comment from sonarqubecloud bot Feb 5, 2026
@mwestphal mwestphal merged commit a051d52 into f3d-app:master Feb 5, 2026
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants