Skip to content

vtkF3DQuakeMDLImporter: Add CanReadFile support#2837

Merged
mwestphal merged 2 commits intof3d-app:masterfrom
mwestphal:mdl_canreadfile
Feb 4, 2026
Merged

vtkF3DQuakeMDLImporter: Add CanReadFile support#2837
mwestphal merged 2 commits intof3d-app:masterfrom
mwestphal:mdl_canreadfile

Conversation

@mwestphal
Copy link
Member

@mwestphal mwestphal commented Jan 30, 2026

Describe your changes

Issue ticket number and link if any

#2493

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@mwestphal mwestphal marked this pull request as ready for review January 30, 2026 10:45
@mwestphal mwestphal changed the title vtkF3DQuakeMDLImporter: Unfinished canreadfile vtkF3DQuakeMDLImporter: Add CanReadFile support Jan 30, 2026
@mwestphal
Copy link
Member Author

\ci full

@mwestphal
Copy link
Member Author

\ci full

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.92%. Comparing base (179e6bb) to head (c77390a).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2837      +/-   ##
==========================================
- Coverage   96.92%   96.92%   -0.01%     
==========================================
  Files         206      206              
  Lines       15702    15751      +49     
==========================================
+ Hits        15219    15266      +47     
- Misses        483      485       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal merged commit 0288aed into f3d-app:master Feb 4, 2026
139 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants