Heretic: send pause input when entering menu during demo recording

[gera2342]

idk if the implementation is correct and fixes all possible ways to desync demos

[fabiangreffrath]

idk if the implementation is correct and fixes all possible ways to desync demos

Please try these while recording a demo:

• pause, unpause
• enter menu, exit menu
• pause, enter menu, exit menu (should unpause)
• enter menu, pause (should have no effect)
• pause, enter menu, unpause (should have no effect)
• anything else?

[gera2342]

enter menu, exit menu

this pauses music, it shouldn't

[gera2342]

Also how does doom manage to leave no pauses in the demo? It seems to stop time rather than injecting pause events.

[rfomin]

Your implementation seems different. See demostarttic in Crispy Doom or basetic in Woof. Also this:

crispy-doom/src/doom/g_game.c

Lines 1233 to 1245 in c3eaaab

	// [crispy] demo pause (from prboom-plus)
	if (gameaction == ga_nothing &&
	(demoplayback || gamestate == GS_DEMOSCREEN))
	{
	if (ev->type == ev_keydown && ev->data1 == key_pause)
	{
	if (paused ^= 2)
	S_PauseSound();
	else
	S_ResumeSound();
	return true;
	}
	}

[fabiangreffrath]

We have the two-stage pause from MBF in Crispy Doom. The paused variable can have values 0, 1 or 2.