Fixes bug with newest dagger version#90
Open
Frisch12 wants to merge 1 commit intofabioCollini:masterfrom
Open
Conversation
Owner
|
Thanks for the PR! Is there an alternative way to do it and avoid using an api available only on Android 24+? The library is a java module so it shouldn't contain any android library dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the newest dagger version the builder is not created with methods for setting the modules but with fields for holding the modules.
This fix will try to look for the method and if no method with module name is found, it will search for a field named as the module.
So every combination of dagger versions is possible.