Fix unit conversion bug (rehash of #30)#32
Merged
danimateos merged 7 commits intofablabbcn:masterfrom Dec 5, 2025
Merged
Conversation
added 7 commits
November 24, 2025 11:19
Some sensors use ° (degrees symbol) while most sensors use º (ordinal indicator) to mean degrees, which was causing a lookup table fail for GB_TEMP
Both diverged during bug fixing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some sensors use ° (degrees symbol) while most sensors use º (ordinal indicator) to mean degrees Celsius.
This was exposed by a misconfiguration in one of the devices, which erroneously had GB_TEMP. This was using °C instead of ºC, which trigerred a lookup table fail during
device.load().Fixed by adding entry to unit_convertion_lut