Skip to content

Commit b967b03

Browse files
shrutipatel31meta-codesync[bot]
authored andcommitted
Skip PredictableMetricsAnalysis for BatchTrials in OverviewAnalysis (#4852)
Summary: Pull Request resolved: #4852 Quick fix to avoid calling PredictableMetricsAnalysis for experiments with BatchTrials until we resolve the shape mismatch issue occurring at https://www.internalfb.com/code/fbsource/[76c3cd2940cf480331df8b1d276e608c60b29d3a]/fbcode/ax/utils/stats/model_fit_stats.py?lines=111 Some users have expressed confusion because of the error raised in this healthcheck hence skipping this healthcheck until the we figure proper fix for this. Reviewed By: eonofrey Differential Revision: D92184502 fbshipit-source-id: 887839839c4ee7a674b2d9b9d13400f542394608
1 parent e984607 commit b967b03

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

ax/analysis/overview.py

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -215,11 +215,15 @@ def compute(
215215
if self.options is not None
216216
else None,
217217
ConstraintsFeasibilityAnalysis(),
218-
PredictableMetricsAnalysis()
219-
if self.model_fit_threshold is None
220-
else PredictableMetricsAnalysis(
221-
model_fit_threshold=self.model_fit_threshold
222-
),
218+
(
219+
PredictableMetricsAnalysis()
220+
if self.model_fit_threshold is None
221+
else PredictableMetricsAnalysis(
222+
model_fit_threshold=self.model_fit_threshold
223+
)
224+
)
225+
if not has_batch_trials
226+
else None,
223227
BaselineImprovementAnalysis() if not has_batch_trials else None,
224228
*[
225229
SearchSpaceAnalysis(trial_index=trial.index)

0 commit comments

Comments
 (0)