Add robust trial status polling#4750
Open
bernardbeckerman wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
Summary: Adds a robust wrapper method for poll_trial_status that: 1. If poll_trial_status fails, falls back to polling trials one-at-a-time. 2. Each trial for which individual status polling fails is marked as abandoned. This is important for runners whose status-polling logic can undergo sporadic exceptions, in order to avoid failing the entire orchestrator process. Alternatives considered: * **Institute a PollStatusResult analogous to [MetricFetchResult](https://fburl.com/code/yyp9j66m).** Decided against because I don't think this logic belongs in runner.poll_trial_status, since it's good to have this centralized instead of replicated across all runners' poll_trial_status methods. Also this would require migration across all runner.poll_trial_status methods. * **Add this to Orchestrator.poll_trial_status (V1 of this diff)**. This could make sense because this logic is mainly for use in the Orchestrator anyway, but I prefer keeping retry logic closer to where polling happens. Differential Revision: D90390842
|
@bernardbeckerman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90390842. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4750 +/- ##
=======================================
Coverage 96.72% 96.72%
=======================================
Files 582 582
Lines 60718 60813 +95
=======================================
+ Hits 58732 58824 +92
- Misses 1986 1989 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
Jan 12, 2026
Summary: Adds a robust wrapper method for poll_trial_status that: 1. If poll_trial_status fails, falls back to polling trials one-at-a-time. 2. Each trial for which individual status polling fails is marked as abandoned. This is important for runners whose status-polling logic can undergo sporadic exceptions, in order to avoid failing the entire orchestrator process. Alternatives considered: * **Institute a PollStatusResult analogous to [MetricFetchResult](https://fburl.com/code/yyp9j66m).** Decided against because I don't think this logic belongs in runner.poll_trial_status, since it's good to have this centralized instead of replicated across all runners' poll_trial_status methods. Also this would require migration across all runner.poll_trial_status methods. * **Add this to Orchestrator.poll_trial_status (V1 of this diff)**. This could make sense because this logic is mainly for use in the Orchestrator anyway, but I prefer keeping retry logic closer to where polling happens. Also considered making this configurable, but opted for an opinionated solution that avoids config bloat. Differential Revision: D90532278
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a robust wrapper method for poll_trial_status that:
This is important for runners whose status-polling logic can undergo sporadic exceptions, in order to avoid failing the entire orchestrator process.
Alternatives considered:
Differential Revision: D90390842