Skip to content

Fix StringDtype vs object dtype mismatch in Data._safecast_df#4795

Open
mgarrard wants to merge 2 commits intofacebook:mainfrom
mgarrard:export-D91185469
Open

Fix StringDtype vs object dtype mismatch in Data._safecast_df#4795
mgarrard wants to merge 2 commits intofacebook:mainfrom
mgarrard:export-D91185469

Conversation

@mgarrard
Copy link
Contributor

@mgarrard mgarrard commented Jan 22, 2026

Summary:
Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from object to
StringDtype(na_value=nan). The _safecast_df() method doesn't properly
handle the comparison between StringDtype and np.dtype("O") because
they are different types that don't compare equal.

Add explicit check for pd.StringDtype to force casting when needed.

Differential Revision: D91185469

@meta-cla meta-cla bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 22, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 22, 2026

@mgarrard has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91185469.

mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 22, 2026
@mgarrard @facebook-github-bot
Fix StringDtype vs object dtype mismatch in Data._safecast_df (facebo…
65db5fb 
…ok#4795)

Summary:

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from `object` to
`StringDtype(na_value=nan)`. The `_safecast_df()` method doesn't properly
handle the comparison between `StringDtype` and `np.dtype("O")` because
they are different types that don't compare equal.

Add explicit check for `pd.StringDtype` to force casting when needed.

Differential Revision: D91185469
mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 22, 2026
@mgarrard @facebook-github-bot
Fix StringDtype vs object dtype mismatch in Data._safecast_df (facebo…
b5dcb3e 
…ok#4795)

Summary:

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from `object` to
`StringDtype(na_value=nan)`. The `_safecast_df()` method doesn't properly
handle the comparison between `StringDtype` and `np.dtype("O")` because
they are different types that don't compare equal.

Add explicit check for `pd.StringDtype` to force casting when needed.

Differential Revision: D91185469
mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 22, 2026
@mgarrard @facebook-github-bot
Fix StringDtype vs object dtype mismatch in Data._safecast_df (facebo…
d9c0986 
…ok#4795)

Summary:

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from `object` to
`StringDtype(na_value=nan)`. The `_safecast_df()` method doesn't properly
handle the comparison between `StringDtype` and `np.dtype("O")` because
they are different types that don't compare equal.

Add explicit check for `pd.StringDtype` to force casting when needed.

Differential Revision: D91185469
mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 22, 2026
@mgarrard @facebook-github-bot
Fix StringDtype vs object dtype mismatch in Data._safecast_df (facebo…
60b3204 
…ok#4795)

Summary:

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from `object` to
`StringDtype(na_value=nan)`. The `_safecast_df()` method doesn't properly
handle the comparison between `StringDtype` and `np.dtype("O")` because
they are different types that don't compare equal.

Add explicit check for `pd.StringDtype` to force casting when needed.

Differential Revision: D91185469
mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 22, 2026
@mgarrard @facebook-github-bot
Fix StringDtype vs object dtype mismatch in Data._safecast_df (facebo…
4c4509d 
…ok#4795)

Summary:

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from `object` to
`StringDtype(na_value=nan)`. The `_safecast_df()` method doesn't properly
handle the comparison between `StringDtype` and `np.dtype("O")` because
they are different types that don't compare equal.

Add explicit check for `pd.StringDtype` to force casting when needed.

Differential Revision: D91185469
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.70%. Comparing base (6045c31) to head (94da5d0).

Files with missing lines Patch % Lines
ax/adapter/cross_validation.py 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4795   +/-   ##
=======================================
  Coverage   96.70%   96.70%           
=======================================
  Files         587      587           
  Lines       61294    61296    +2     
=======================================
+ Hits        59275    59277    +2     
  Misses       2019     2019

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 22, 2026
@mgarrard @facebook-github-bot
Fix StringDtype vs object dtype mismatch in Data._safecast_df (facebo…
f0b1e03 
…ok#4795)

Summary:

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from `object` to
`StringDtype(na_value=nan)`. The `_safecast_df()` method doesn't properly
handle the comparison between `StringDtype` and `np.dtype("O")` because
they are different types that don't compare equal.

Add explicit check for `pd.StringDtype` to force casting when needed.

Differential Revision: D91185469
@mgarrard @facebook-github-bot
Fix read-only numpy arrays in cross-validation (facebook#4794)
b5cbb5a 
Summary:

I'm not sure why these are showing up as failures today, we migrated to Python scientific stack in july 2024, but these are deprecation warnings we should go ahead and take care of anyway. Figured would knock them out while they are causing me issues

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA


Add `.copy()` after `.numpy()` calls to ensure arrays are writeable.
PyTorch tensors converted via `.detach().cpu().numpy()` return read-only
arrays in some cases. The subsequent squeeze operations create read-only
views, and the in-place assignment `loo_covs[:, diag_idx, diag_idx] = loo_vars`
fails with "assignment destination is read-only" error.

Differential Revision: D91185467
@mgarrard @facebook-github-bot
Fix StringDtype vs object dtype mismatch in Data._safecast_df (facebo…
94da5d0 
…ok#4795)

Summary:

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from `object` to
`StringDtype(na_value=nan)`. The `_safecast_df()` method doesn't properly
handle the comparison between `StringDtype` and `np.dtype("O")` because
they are different types that don't compare equal.

Add explicit check for `pd.StringDtype` to force casting when needed.

Differential Revision: D91185469
mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 22, 2026
@mgarrard @facebook-github-bot
Fix StringDtype vs object dtype mismatch in Data._safecast_df (facebo…
d63cf1d 
…ok#4795)

Summary:

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from `object` to
`StringDtype(na_value=nan)`. The `_safecast_df()` method doesn't properly
handle the comparison between `StringDtype` and `np.dtype("O")` because
they are different types that don't compare equal.

Add explicit check for `pd.StringDtype` to force casting when needed.

Differential Revision: D91185469
mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 22, 2026
@mgarrard @facebook-github-bot
Fix StringDtype vs object dtype mismatch in Data._safecast_df (facebo…
a321920 
…ok#4795)

Summary:

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from `object` to
`StringDtype(na_value=nan)`. The `_safecast_df()` method doesn't properly
handle the comparison between `StringDtype` and `np.dtype("O")` because
they are different types that don't compare equal.

Add explicit check for `pd.StringDtype` to force casting when needed.

Differential Revision: D91185469
mgarrard added a commit to mgarrard/Ax that referenced this pull request Jan 22, 2026
@mgarrard @facebook-github-bot
Fix StringDtype vs object dtype mismatch in Data._safecast_df (facebo…
962be89 
…ok#4795)

Summary:

Prompted after some failures in exports not related to my changes: https://github.com/facebook/Ax/actions/runs/21225324302/job/61070638075?fbclid=IwY2xjawPeXMFleHRuA2FlbQIxMQBicmlkETFRTkR6WlE4NHVrd3IyQXNlc3J0YwZhcHBfaWQBMAABHjTAiZi71n24w95hvzEewrKNPKOGzJisgR7t4qJ3APRMYlusgFC-gu7RLiSb_aem_Zk3pmTDonCFsJvZCTkpeMA

Pandas 2.0+ changed default string column dtype from `object` to
`StringDtype(na_value=nan)`. The `_safecast_df()` method doesn't properly
handle the comparison between `StringDtype` and `np.dtype("O")` because
they are different types that don't compare equal.

Add explicit check for `pd.StringDtype` to force casting when needed.

Differential Revision: D91185469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgarrard @codecov-commenter