Add TorchAdapter.botorch_model property#4827
Open
saitcakmak wants to merge 1 commit intofacebook:mainfrom
Open
Add TorchAdapter.botorch_model property#4827saitcakmak wants to merge 1 commit intofacebook:mainfrom
saitcakmak wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91588495. |
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4827 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 588 588
Lines 61560 61580 +20
=======================================
+ Hits 59556 59576 +20
Misses 2004 2004 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary: This is a convenience method that should save us from doing calls like `client._generation_strategy.adapter.generator.surrogate.model` and instead simplify it to `client._generation_strategy.adapter.botorch_model`. Differential Revision: D91588495
saitcakmak
force-pushed
the
export-D91588495
branch
from
2fb2161 to
5abe7fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: This is a convenience method that should save us from doing calls like
client._generation_strategy.adapter.generator.surrogate.modeland instead simplify it toclient._generation_strategy.adapter.botorch_model.Differential Revision: D91588495