Show all healthcheck cards sorted by severity and priority#4835
Open
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Open
Show all healthcheck cards sorted by severity and priority#4835shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Previously, the overview analysis only displayed non-passing healthcheck cards. This change shows all healthcheck cards, sorted by severity and priority to surface the most important information first. The sorting order is: 1. ErrorAnalysisCard (errors during computation) 2. FAIL status 3. WARNING status 4. PASS status with priority (BaselineImprovementAnalysis, EarlyStoppingAnalysis - these provide valuable progress metrics even when passing) 5. PASS status (rest) This gives users visibility into the full health of their experiment while keeping critical issues at the top. Differential Revision: D91750384
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91750384. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4835 +/- ##
==========================================
- Coverage 96.74% 96.74% -0.01%
==========================================
Files 588 589 +1
Lines 61526 61551 +25
==========================================
+ Hits 59524 59546 +22
- Misses 2002 2005 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, the overview analysis only displayed non-passing healthcheck cards. This change shows all healthcheck cards, sorted by severity and priority to surface the most important information first.
The sorting order is:
This gives users visibility into the full health of their experiment while keeping critical issues at the top.
Differential Revision: D91750384