Handle all-infeasible traces in UtilityProgressionAnalysis#4837
Open
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Open
Handle all-infeasible traces in UtilityProgressionAnalysis#4837shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Conversation
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91751120. |
meta-cla
bot
added
the
CLA Signed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4837 +/- ##
=======================================
Coverage 96.74% 96.75%
=======================================
Files 589 589
Lines 61623 61634 +11
=======================================
+ Hits 59617 59631 +14
+ Misses 2006 2003 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…4837) Summary: When `get_trace` returns all infeasible points (represented as `inf` or `-inf` values), the utility progression plot would previously attempt to plot these infinite values. This change adds a check to raise an `ExperimentNotReadyError` with a clear message when all trials are infeasible, preventing the plot from displaying meaningless data. Differential Revision: D91751120
shrutipatel31
force-pushed
the
export-D91751120
branch
from
ccb4851 to
b6d3486
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: When
get_tracereturns all infeasible points (represented asinfor-infvalues), the utility progression plot would previously attempt to plot these infinite values. This change adds a check to raise anExperimentNotReadyErrorwith a clear message when all trials are infeasible, preventing the plot from displaying meaningless data.Differential Revision: D91751120