fix: upgrade @svgr/webpack from v5.5.0 to v8.1.0#17194
fix: upgrade @svgr/webpack from v5.5.0 to v8.1.0#17194Kristianwhittick wants to merge 3 commits intofacebook:mainfrom
Conversation
- Resolves deprecation warnings for svgo@1.3.2 and stable@0.1.8 - @svgr/webpack v8 includes svgo v3 which no longer uses the deprecated stable package - Configuration remains compatible with v8
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Adds standalone test script to verify: - package.json has @svgr/webpack v8+ - webpack config includes @svgr/webpack loader - svgr options are properly configured Run with: node packages/react-scripts/verify-svgr-upgrade.test.js
Testing UpdateAdded verification test in commit 9fca391: node packages/react-scripts/verify-svgr-upgrade.test.jsTest Results:
All tests pass. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
Summary
Upgrades @svgr/webpack from v5.5.0 to v8.1.0 to resolve deprecation warnings.
Motivation
svgo@1.3.2stable@0.1.8(transitive dependency)Changes
Testing
import logo from './logo.svg'andimport { ReactComponent as Logo } from './logo.svg'patterns are testedRelated