Skip to content

Add icetea new platform Asic config and cpp files#531

Closed
cel-gl wants to merge 2 commits intofacebook:mainfrom
cel-gl:icetea_main
Closed

Add icetea new platform Asic config and cpp files#531
cel-gl wants to merge 2 commits intofacebook:mainfrom
cel-gl:icetea_main

Conversation

@cel-gl
Copy link
Contributor

@cel-gl cel-gl commented Sep 3, 2025

Description
IceTea New Platform Support Development:

agent code
Add a SaiBcm{PLATFORM}PlatformPort header and source file for your platform:
fboss/agent/platforms/sai/SaiBcm{PLATFORM}PlatformPort.h Header example
fboss/agent/platforms/sai/SaiBcm{PLATFORM}PlatformPort.cpp Source example
Add a SaiBcm{PLATFORM}Platform header and source file for your platform:
fboss/agent/platforms/sai/SaiBcm{PLATFORM}Platform.h Header example
fboss/agent/platforms/sai/SaiBcm{PLATFORM}Platform.cpp Source example
Add a new entry to initPorts() in fboss/agent/platforms/sai/SaiPlatform.cpp.
Add a new entry to chooseSaiPlatform() in fboss/agent/platforms/sai/SaiPlatformInit.cpp.
Make changes to CMake files to support building in open source:
Add cmake/AgentPlatformsCommon{PLATFORM}.cmake for your platform (Example)
Then add this library name to sai_platform link libraries in cmake/AgentPlatformsSai.cmake

Motivation
Develop the IceTea platform support according to the new platform support guide, https://facebook.github.io/fboss/docs/developing/new_platform_support/

Test Plan
current compile without error, need icetea switch config files for test

@meta-cla
Copy link

meta-cla bot commented Sep 3, 2025

Hi @cel-gl!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@shiva-menta
Copy link
Contributor

@cel-gl Can you please fill out the CLA? We would like to see the results of the GitHub actions before reviewing / merging in. Let us know if you run into any issues.

@cel-gl
Copy link
Contributor Author

cel-gl commented Sep 4, 2025

@cel-gl Can you please fill out the CLA? We would like to see the results of the GitHub actions before reviewing / merging in. Let us know if you run into any issues.

ok, I have signed and receive email "A third-party OAuth application (Facebook) with access to public information (read-only) was recently authorized to access your account.." ,

@meta-cla meta-cla bot added the CLA Signed label Sep 4, 2025
@meta-cla
Copy link

meta-cla bot commented Sep 4, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@shiva-menta
Copy link
Contributor

@cel-gl Can you rebase this PR and resubmit? This will allow Github actions to run and validate your changes. Thanks so much.

@cel-gl
Copy link
Contributor Author

cel-gl commented Sep 4, 2025

@cel-gl Can you rebase this PR and resubmit? This will allow Github actions to run and validate your changes. Thanks so much.

ok, I will do it asap

@shiva-menta
Copy link
Contributor

@cel-gl Can you please add icetea800bc to this file (

)?

This will fix the Platform Mapping Generation job.

I will add documentation to include this instruction moving forward.

@cel-gl
Copy link
Contributor Author

cel-gl commented Sep 5, 2025

@cel-gl Can you please add icetea800bc to this file (

)?
This will fix the Platform Mapping Generation job.

I will add documentation to include this instruction moving forward.

done

@facebook-github-bot
Copy link
Contributor

@shiva-menta has imported this pull request. If you are a Meta employee, you can view this in D81800239.

@facebook-github-bot
Copy link
Contributor

@shiva-menta merged this pull request in 713d3a0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants