Ladakh800bcls: fix error 'Check failure stack trace' in AgentCopp*Test#912
Open
gang-tao wants to merge 1 commit intofacebook:mainfrom
Open
Ladakh800bcls: fix error 'Check failure stack trace' in AgentCopp*Test#912gang-tao wants to merge 1 commit intofacebook:mainfrom
gang-tao wants to merge 1 commit intofacebook:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runclang-format.............................................................Passed
black................................................(no files to check)Skipped
shellcheck...........................................(no files to check)Skipped
shfmt................................................(no files to check)Skipped
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check json...........................................(no files to check)Skipped
check for merge conflicts................................................Passed
ruff check...........................................(no files to check)Skipped
Summary
run case failed as below.
F20260131 22:24:09.467856 69362 MultiSwitchHwSwitchHandler.cpp:416] Check failed: !transaction
*** Check failure stack trace: ***
Motivation
The test case failed because switch_id now need to be provided via command-line arguments according to the new requirements, but this wasn't updated. I am now applying the changes based on this commit.
6bba436#diff-a1e2a2b7d5175cc5451fbbde6dce83e58ed018ca8eb4f538c6e354bfa929a7cc
Test Plan
command
result