Skip to content

Ladakh800bcls: fix error 'Check failure stack trace' in AgentCopp*Test#912

Open
gang-tao wants to merge 1 commit intofacebook:mainfrom
gang-tao:ladakh800bcls_agent_fix3
Open

Ladakh800bcls: fix error 'Check failure stack trace' in AgentCopp*Test#912
gang-tao wants to merge 1 commit intofacebook:mainfrom
gang-tao:ladakh800bcls_agent_fix3

Conversation

@gang-tao
Copy link
Contributor

@gang-tao gang-tao commented Feb 8, 2026

Pre-submission checklist

  • [✓ ] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • [✓ ] pre-commit run
    clang-format.............................................................Passed
    black................................................(no files to check)Skipped
    shellcheck...........................................(no files to check)Skipped
    shfmt................................................(no files to check)Skipped
    trim trailing whitespace.................................................Passed
    fix end of files.........................................................Passed
    check yaml...........................................(no files to check)Skipped
    check json...........................................(no files to check)Skipped
    check for merge conflicts................................................Passed
    ruff check...........................................(no files to check)Skipped

Summary

run case failed as below.
F20260131 22:24:09.467856 69362 MultiSwitchHwSwitchHandler.cpp:416] Check failed: !transaction
*** Check failure stack trace: ***

Motivation

The test case failed because switch_id now need to be provided via command-line arguments according to the new requirements, but this wasn't updated. I am now applying the changes based on this commit.
6bba436#diff-a1e2a2b7d5175cc5451fbbde6dce83e58ed018ca8eb4f538c6e354bfa929a7cc

Test Plan

command

for filter in AgentCoppTest/1.LocalDstIpBgpPortToHighPriQ AgentCoppTest/1.LocalDstIpBgpPortToHighPriQ AgentCoppTest/1.LocalDstIpNonBgpPortToMidPriQ AgentCoppTest/1.Ipv6LinkLocalMcastToMidPriQ AgentCoppTest/1.Ipv6LinkLocalMcastTxFromCpu AgentCoppTest/1.Ipv6LinkLocalUcastToMidPriQ AgentCoppTest/1.SlowProtocolsMacToHighPriQ AgentCoppTest/1.CpuPortIpv6LinkL
ocalUcastIp AgentCoppTest/1.Ipv6LinkLocalMcastNetworkControlDscpToHighPriQ AgentCoppTest/1.ArpRequestAndReplyToHighPriQ AgentCoppTest/1.NdpSolicitationToHighPriQ AgentCoppTest/1.NdpSolicitNeighbor AgentCoppTest/1.NdpAdvertisementToHighPriQ AgentCoppTest/1.UnresolvedRoutesToLowPriQueue AgentCoppTest/1.JumboFrame
sToQueues AgentCoppTest/1.LldpProtocolToMidPriQ AgentCoppTest/1.Ttl1PacketToLowPriQ AgentCoppTest/1.DHCPv6SolicitToMidPriQ AgentCoppTest/1.DHCPv6AdvertiseToMidPriQ AgentCoppEapolTest/1.EapolToHighPriQ AgentPacketSendReceiveLagTest.LacpPacketReceiveSrcPort ; do
    LD_LIBRARY_PATH=/opt/fboss/lib/ /root/gangtao/img/multi_switch_agent_hw_test
    --gtest_filter=${filter}
    --config /root/gangtao/cfg/link_test_config
    --platform_mapping_override_path /root/gangtao/cfg/ladakh800bc_platform_mapping_is_multi_npu.json-no-65
    --multi_npu_platform_mapping
    --switch_id_for_testing 0
    --logging=DBG5
done

result

multi_switch_agent-20260208_142459.log:[       OK ] AgentCoppTest/1.LocalDstIpBgpPortToHighPriQ (34568 ms)
multi_switch_agent-20260208_143210.log:[       OK ] AgentCoppTest/1.LocalDstIpNonBgpPortToMidPriQ (32663 ms)
multi_switch_agent-20260208_143442.log:[       OK ] AgentCoppTest/1.Ipv6LinkLocalUcastToMidPriQ (34057 ms)
multi_switch_agent-20260208_143342.log:[       OK ] AgentCoppTest/1.Ipv6LinkLocalMcastTxFromCpu (46576 ms)
multi_switch_agent-20260208_143529.log:[       OK ] AgentCoppTest/1.SlowProtocolsMacToHighPriQ (36530 ms)
multi_switch_agent-20260208_143618.log:[       OK ] AgentCoppTest/1.CpuPortIpv6LinkLocalUcastIp (32966 ms)
multi_switch_agent-20260208_143704.log:[       OK ] AgentCoppTest/1.Ipv6LinkLocalMcastNetworkControlDscpToHighPriQ (33931 ms)
multi_switch_agent-20260208_143845.log:[       OK ] AgentCoppTest/1.NdpSolicitationToHighPriQ (37095 ms)
multi_switch_agent-20260208_143751.log:[       OK ] AgentCoppTest/1.ArpRequestAndReplyToHighPriQ (41251 ms)
multi_switch_agent-20260208_143936.log:[       OK ] AgentCoppTest/1.NdpSolicitNeighbor (37434 ms)
multi_switch_agent-20260208_144026.log:[       OK ] AgentCoppTest/1.NdpAdvertisementToHighPriQ (37197 ms)
multi_switch_agent-20260208_144116.log:[       OK ] AgentCoppTest/1.UnresolvedRoutesToLowPriQueue (34010 ms)
multi_switch_agent-20260208_144253.log:[       OK ] AgentCoppTest/1.LldpProtocolToMidPriQ (36939 ms)
multi_switch_agent-20260208_144203.log:[       OK ] AgentCoppTest/1.JumboFramesToQueues (36353 ms)
multi_switch_agent-20260208_144343.log:[       OK ] AgentCoppTest/1.Ttl1PacketToLowPriQ (37072 ms)
multi_switch_agent-20260208_144433.log:[       OK ] AgentCoppTest/1.DHCPv6SolicitToMidPriQ (42551 ms)
multi_switch_agent-20260208_144528.log:[       OK ] AgentCoppTest/1.DHCPv6AdvertiseToMidPriQ (41036 ms)
multi_switch_agent-20260208_144623.log:[       OK ] AgentCoppEapolTest/1.EapolToHighPriQ (37163 ms)
multi_switch_agent-20260208_143255.log:[       OK ] AgentCoppTest/1.Ipv6LinkLocalMcastToMidPriQ (33469 ms)

@meta-cla meta-cla bot added the CLA Signed label Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant