Skip to content

[Accton] Fix a bug that benchmark can't run continuous sub-tests.#933

Open
BrandonCheng0121 wants to merge 1 commit intofacebook:mainfrom
BrandonCheng0121:benchmark-fix-run-continuous-sub-tests-issue
Open

[Accton] Fix a bug that benchmark can't run continuous sub-tests.#933
BrandonCheng0121 wants to merge 1 commit intofacebook:mainfrom
BrandonCheng0121:benchmark-fix-run-continuous-sub-tests-issue

Conversation

@BrandonCheng0121
Copy link

@BrandonCheng0121 BrandonCheng0121 commented Feb 12, 2026

Description:
This fix can make the benchmark run continuous sub-tests instead of only running them individually.

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
    pre-commit run --files fboss/agent/SwSwitch.cpp
    pre-commit run --files fboss/lib/restart_tracker/RestartTimeTracker.cpp

Summary

Test Plan

The benchmark, sai_stats_collection_speed-sai_impl, has been tested. With the fix, it can test two sub-tests within it in a test run.
The related post in workplace is https://fb.workplace.com/groups/externalmp3nfbossacctonmeta/permalink/1250282870307419/
And the other benchmark, sai_fsw_scale_route_add_speed-sai_impl, that has only one sub-test, is also tested.

@meta-cla
Copy link

meta-cla bot commented Feb 12, 2026

Hi @BrandonCheng0121!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@BrandonCheng0121 BrandonCheng0121 marked this pull request as draft February 12, 2026 10:44
@meta-cla
Copy link

meta-cla bot commented Feb 12, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Feb 12, 2026
Description:
This fix can make the benchmark run continuous sub-tests instead of
only running them individually.

 Author:    brandon_cheng <brandon_cheng@accton.com>
@BrandonCheng0121 BrandonCheng0121 force-pushed the benchmark-fix-run-continuous-sub-tests-issue branch from 20de484 to 2033f0a Compare February 13, 2026 07:18
@BrandonCheng0121 BrandonCheng0121 marked this pull request as ready for review February 13, 2026 07:33
@BrandonCheng0121 BrandonCheng0121 marked this pull request as draft February 13, 2026 07:49
@BrandonCheng0121 BrandonCheng0121 changed the title [Accton] Fix a bug that benchmark can't run continous sub-tests. [Accton] Fix a bug that benchmark can't run continuous sub-tests. Feb 13, 2026
@BrandonCheng0121 BrandonCheng0121 marked this pull request as ready for review February 13, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant