[DOCS] Improve docs about callable property#7790
Open
wgao19 wants to merge 2 commits intofacebook:mainfrom
Open
[DOCS] Improve docs about callable property#7790wgao19 wants to merge 2 commits intofacebook:mainfrom
wgao19 wants to merge 2 commits intofacebook:mainfrom
Conversation
Contributor
|
Function statics isn't https://flow.org/try/#0GYVwdgxgLglg9mABMAFASkQbwL4ChfAB0wccQA |
Contributor
Author
|
Is it about function type statics? Because I read in this commit that function type statics has been changed to "an empty, inexact object type". I'm wondering if rephrasing it as follows will be more accurate and clearer:
type F = () => void;
const f: F = () => {
f.foo = 'bar'; // $ExpectError "missing in statics of function type"
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #7777, this PR hopes to improve docs around callable property.
The content of these edits credits to the discussions at niieani/typescript-vs-flowtype#55, especially insights from @omninonsense and @goodmind. Would really appreciate your inputs on this revision to the docs as well.