Enhance SimpleAllocator with size validation#2558
Open
wangqin0 wants to merge 1 commit intofacebook:mainfrom
Open
Enhance SimpleAllocator with size validation#2558wangqin0 wants to merge 1 commit intofacebook:mainfrom
wangqin0 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Added a static assertion to ensure that the size passed to SimpleAllocator is at least the size of a pointer. If the size is smaller, an exception is thrown. Updated documentation to clarify that allocations smaller than sizeof(void*) are rounded up. Added a new test case to verify the behavior of coreMalloc for small allocations.
Author
|
closes #2538 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimpleAllocatorconstructor to ensure minimum allocation size ofsizeof(void*)CacheLocality.hto clarify that allocations smaller thansizeof(void*)are rounded upCoreAllocator.MinimumAllocationSizeto verify correct behavior for small allocationsTest plan
CoreAllocator.MinimumAllocationSizethat verifies 1-byte, 4-byte, and 8-byte allocations work correctlyCacheLocalityTestsuite to ensure no regressions