Open
Conversation
facebook-github-bot
added
the
CLA Signed
Author
|
Once #477 is merged internally I'll rebase this, just wanted to get it up so it can be reviewed |
grodin
force-pushed
the
grodin/cli-style-option
branch
from
925e6cc to
93568fa
Compare
Contributor
|
Looks like you have to update the tests in order to make it all compile And then the webpage to send in the right data now |
Author
|
I keep forgetting about the enclosed gradle builds! |
Contributor
|
@grodin are you still going to work on those? |
Author
|
I do plan to. It's a little hectic here with school summer holidays so I don't think I'll have a chance this week |
Contributor
|
@grodin, would you mind if I take over and finish working on the final bits? Credit would still go to you though |
Author
|
No problem, feel free |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed at #391 (comment)
To be landed on top of #477