feat: expose modules in runtime both in development and production#1645
Open
tjzel wants to merge 1 commit intofacebook:mainfrom
Open
feat: expose modules in runtime both in development and production#1645tjzel wants to merge 1 commit intofacebook:mainfrom
tjzel wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose
getModulesfunction in both development and release environments. This allows the developers to dynamically replace a module in runtime.I personally use it in
react-native-workletsto replacereact-nativemodule on extra JavaScript runtimes.react-nativemodule includes side-effects that are fatal on these extra runtimes and replacing it with a mock module improves developer experience significantly, in case they importreact-nativeaccidentally in runtime.Changelog: [Feature] Expose modules in runtime both in development and production
Test plan
Nothing to test really.