Only show bug reporting URL in non-debug builds#2228
Closed
fangyi-zhou wants to merge 1 commit intofacebook:mainfrom
Closed
Only show bug reporting URL in non-debug builds#2228fangyi-zhou wants to merge 1 commit intofacebook:mainfrom
fangyi-zhou wants to merge 1 commit intofacebook:mainfrom
Conversation
Conformance test expectation files contains the error reporting URL which deviates between fbcode builds (for Meta environements) and open-source environments. This change suppresses some noise due to environment differences.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
@yangdanny97 has imported this pull request. If you are a Meta employee, you can view this in D91474069. |
Contributor
|
given there's only a few cases let's just fix the internal error, ideally they shouldn't show up at all in conformance tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Conformance test expectation files contains the error reporting URL which deviates between fbcode builds (for Meta environements) and open-source environments. This change suppresses some noise due to environment differences.
Test Plan
Regenerated conformance test expectation files and observed that the bug reporting URL is removed.