Emit config diagnostics #2289
Open
Emit config diagnostics #2289
+233
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit diagnostics for config file parse errors (facebook#2078) Config errors (pyrefly.toml/pyproject.toml) now appear as LSP diagnostics in the Problems panel and clear when fixed.
sgavriil01
force-pushed
the
emit-config-diagnostics
branch
from
c487ef4 to
5393991
Compare
sgavriil01
force-pushed
the
emit-config-diagnostics
branch
from
5393991 to
7e85055
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds LSP diagnostics for config file (pyrefly.toml/pyproject.toml) parsing errors. When a config file has invalid syntax, diagnostics now appear in VS Code's Problems panel and clear automatically when the file is fixed.
Changes:
ConfigErrorto include file path informationworkspace.rswhere config errors were being discardedpublish_config_diagnostics()to emit LSP diagnostics for config filesFixes #2078
Test Plan
test_config_file_diagnostics()that creates invalid TOML and verifies proper handling./test.py --no-test --no-conformance- formatting and linting pass