Remove Danger.js workflow and dependencies #55385
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [INTERNAL] [CHANGED] - Add api-changes.yml workflow to replace danger-pr for detecting changes in the js api The workflow: - Triggers on `pull_request_target` for opened, edited, reopened, and synchronize events - Checks out the main branch (for security, using trusted code) - Runs the `diff-js-api-changes` action to detect API changes - Posts a PR comment using the generic `post-pr-comment` action The PR comment script creates, updates, or deletes a bot comment based on whether there are any sections to report, using a marker to identify existing bot comments. Reviewed By: huntie Differential Revision: D90991845
Summary: This adds a `validatePRBody.js` script that checks pull request descriptions for required sections as part of a new `analyze-pr.yml` workflow that will replace part of the Danger-pr workflow. The validation includes: - **Description length check**: Fails if the PR body is missing or less than 50 characters - **Summary section check**: Warns if the PR lacks a "## Summary" section - **Test plan check**: Warns if the PR lacks a "## Test Plan" section - **Changelog validation**: failing if missing or invalid Key behaviors: - Phabricator-sourced PRs (detected via "Differential Revision:" in body) skip summary, test plan, and changelog validation since these are enforced differently - Validation messages use GitHub's `[!WARNING]` and `[!CAUTION]` callout syntax for clear visual feedback - The workflow fails (via `core.setFailed`) when any required check fails - Messages are passed to `postPRComment` alongside API changes for consolidated PR comments This aims to mimic relevant parts of dangerfile.js Reviewed By: huntie Differential Revision: D91158803
Summary: Adds a branch targeting validation that replaces the equivalent Danger.js check. The check validates that PRs target either `main` or a `-stable` branch, and automatically adds the "Pick Request" label when targeting stable branches. - Created `checkBranchTarget.js` - pure function returning validation message - Added check step to `annotate-pr.yml` that calls the JS and adds labels - Added `issues: write` permission for label functionality Differential Revision: D91685081
Summary: Now that all Danger.js checks have been migrated to native GitHub Actions in the `annotate-pr.yml` workflow, this removes the deprecated Danger infrastructure: - Deletes `.github/workflows/danger-pr.yml` workflow - Deletes `private/react-native-bots/dangerfile.js` - Removes `danger` npm dependency from `react-native-bots/package.json` The functionality previously provided by Danger.js is now handled by: - **API diff detection**: `diff-js-api-changes` action - **PR body validation**: `validatePRBody.js` script (summary, test plan, changelog checks) - **Branch targeting**: `checkBranchTarget.js` script (validates target branch, adds "Pick Request" label) - **PR commenting**: `post-pr-comment` action This simplifies the CI pipeline by removing the third-party Danger dependency and consolidating PR annotation logic into maintainable GitHub Actions workflows. Differential Revision: D91695886
meta-cla
bot
added
the
CLA Signed
|
@emily8rown has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91695886. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Now that all Danger.js checks have been migrated to native GitHub Actions in the
annotate-pr.ymlworkflow, this removes the deprecated Danger infrastructure:.github/workflows/danger-pr.ymlworkflowprivate/react-native-bots/dangerfile.jsdangernpm dependency fromreact-native-bots/package.jsonThe functionality previously provided by Danger.js is now handled by:
diff-js-api-changesactionvalidatePRBody.jsscript (summary, test plan, changelog checks)checkBranchTarget.jsscript (validates target branch, adds "Pick Request" label)post-pr-commentactionThis simplifies the CI pipeline by removing the third-party Danger dependency and consolidating PR annotation logic into maintainable GitHub Actions workflows.
Differential Revision: D91695886