Fix URL constructor type to accept URL as first argument#55402
Open
emily8rown wants to merge 1 commit intofacebook:mainfrom
Open
Fix URL constructor type to accept URL as first argument#55402emily8rown wants to merge 1 commit intofacebook:mainfrom
emily8rown wants to merge 1 commit intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@emily8rown has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92271127. |
) Summary: According to the URL API specification, the first parameter is a USVString, which accepts anything stringifiable. Since URL objects are stringifiable, they should be accepted. This change mirrors what we already do for the `base` parameter, which accepts `string | URL` and the spec also expects USVString. ## Changelog: [GENERAL] [Changed] - Changed Flow type for `URL` constructor to accept `URL` as first argument, matching the second argument type https://url.spec.whatwg.org/#dom-url-url Differential Revision: D92271127
emily8rown
force-pushed
the
export-D92271127
branch
from
0940e65 to
706a031
Compare
emily8rown
added a commit
to emily8rown/react-native
that referenced
this pull request
Feb 4, 2026
) Summary: According to the URL API specification, the first parameter is a USVString, which accepts anything stringifiable. Since URL objects are stringifiable, they should be accepted. This change mirrors what we already do for the `base` parameter, which accepts `string | URL` and the spec also expects USVString. ## Changelog: [GENERAL] [Changed] - Changed Flow type for `URL` constructor to accept `URL` as first argument, matching the second argument type https://url.spec.whatwg.org/#dom-url-url Differential Revision: D92271127
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
According to the URL API specification, the first parameter is a USVString, which accepts anything stringifiable. Since URL objects are stringifiable, they should be accepted.
This change mirrors what we already do for the
baseparameter, which acceptsstring | URLand the spec also expects USVString.Changelog:
[GENERAL] [Changed] - Changed Flow type for
URLconstructor to acceptURLas first argument, matching the second argument typehttps://url.spec.whatwg.org/#dom-url-url
Differential Revision: D92271127