Stub internals of Paper Text ShadowNodes#55438
Open
NickGerleman wants to merge 5 commits intofacebook:mainfrom
Open
Stub internals of Paper Text ShadowNodes#55438NickGerleman wants to merge 5 commits intofacebook:mainfrom
NickGerleman wants to merge 5 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92481655. |
NickGerleman
force-pushed
the
export-D92481655
branch
from
5a2b20b to
79d0dda
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 6, 2026
Summary: All of this is dead, but still uses the text infra by Fabric that we continue to change. Lets stub out the internals of the ShadowNodes, to make it easier to edit RN text internals, and shave some code/space. mdvacca or cortinico should be able to tell if this will cause issues with interop layer. Changelog: [Internal] Differential Revision: D92481655
NickGerleman
force-pushed
the
export-D92481655
branch
from
79d0dda to
8656716
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 6, 2026
Summary: All of this is dead, but still uses the text infra by Fabric that we continue to change. Lets stub out the internals of the ShadowNodes, to make it easier to edit RN text internals, and shave some code/space. mdvacca or cortinico should be able to tell if this will cause issues with interop layer. Changelog: [Internal] Differential Revision: D92481655
cortinico
approved these changes
Feb 6, 2026
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
NickGerleman
force-pushed
the
export-D92481655
branch
from
8656716 to
949a632
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Feb 6, 2026
Summary: All of this is dead, but still uses the text infra by Fabric that we continue to change. Lets stub out the internals of the ShadowNodes, to make it easier to edit RN text internals, and shave some code/space. mdvacca or cortinico should be able to tell if this will cause issues with interop layer. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D92481655
Summary: This is used by `Image`, to render a different component when under a `TextAncestorContext`, but the underlying component is remapped by Fabric to instead be interpreted as `Image`. We can delete the code JS side safely, since it will use the existing registered View manager, Fabric will already redirect to. We can also then delete the redirection in Fabric, since the component is no longer ever used. See `componentNameByReactViewName.cpp`, where this is also removed. Changelog: [Internal] Reviewed By: mdvacca, javache, cortinico Differential Revision: D92481981
…acebook#55435) Summary: This is never used when using Fabric. Reviewed By: javache, cortinico Differential Revision: D92482459
Summary: The component is no longer referenced anywhere after the previous changes, and can be deleted. Reviewed By: cortinico Differential Revision: D92484075
facebook#55437) Summary: This deletes some Paper specific paths in Text and image code, related to inline view handling (done in native component layer in Paper), and how padding is set. It also changed `Spannable` to `Spanned` in a couple places, in preparation of reusing `ReactTextViewManager` with state generated by Facsimile (for selectable text). I left the actions performed by Paper ShadowNode as something stublike, since that code should never be executed. `ReactTextUpdate` is made internal, since the shape of native component state is subject to change. Changelog: [Android][Breaking] - Make ReactTextUpdate internal Differential Revision: D92459725
Summary: All of this is dead, but still uses the text infra by Fabric that we continue to change. Lets stub out the internals of the ShadowNodes, to make it easier to edit RN text internals, and shave some code/space. mdvacca or cortinico should be able to tell if this will cause issues with interop layer. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D92481655
NickGerleman
force-pushed
the
export-D92481655
branch
from
949a632 to
2366ef1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
All of this is dead, but still uses the text infra by Fabric that we continue to change. Lets stub out the internals of the ShadowNodes, to make it easier to edit RN text internals, and shave some code/space.
mdvacca or cortinico should be able to tell if this will cause issues with interop layer.
Changelog: [Internal]
Differential Revision: D92481655