Open
Conversation
meta-cla
bot
added
the
CLA Signed
Summary: Node.js `createServer` options for the `net`, `tls`, `http` and `https` modules are currently unclearly typed as just `Object`. This adds full typing for all options as of Node.js 24. Changelog: [Internal] Differential Revision: D92393810
facebook-github-bot
force-pushed
the
export-D92393810
branch
from
8952294 to
1c747ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Node.js
createServeroptions for thenet,tls,httpandhttpsmodules are currently unclearly typed as justObject.This adds full typing for all options as of Node.js 24.
Changelog: [Internal]
Differential Revision: D92393810