Restrict npm publish job to main branch and version tags#5156
Closed
captbaritone wants to merge 1 commit intofacebook:mainfrom
Closed
Restrict npm publish job to main branch and version tags#5156captbaritone wants to merge 1 commit intofacebook:mainfrom
captbaritone wants to merge 1 commit intofacebook:mainfrom
Conversation
Add branch/tag condition to the main-release job to avoid permission errors when the job runs on non-main branches. The npm-publish environment permissions cause GitHub to fail the job early on branches that don't have access.
Contributor
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this in D91795710. |
Contributor
|
@captbaritone merged this pull request in 3d2629a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main-releasejob to only run on pushes tomainor version tags (e.g.,v1.0.0)npm-publishenvironment is not accessibleTest plan
main-releasejob should be skipped)