This repository was archived by the owner on Dec 15, 2020. It is now read-only.
fix: head locked surfaces sample#800
Open
darde wants to merge 1 commit intofacebookarchive:masterfrom
darde:fix-headlocked-surfaces-sample
Open
fix: head locked surfaces sample#800darde wants to merge 1 commit intofacebookarchive:masterfrom darde:fix-headlocked-surfaces-sample
darde wants to merge 1 commit intofacebookarchive:masterfrom
darde:fix-headlocked-surfaces-sample
Conversation
This PR adds a few modifications to allow the HeadLockedSurfaces sample run 1. Adds the webgl-ui library thats provide the rotateQuaternion method 2. Use the native JavaScript class Math to provide the trigonometric functions
|
Hi @darde! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few modifications to allow the HeadLockedSurfaces sample run
Motivation (required)
The current HeadLockedSurfaces sample is broken, and there are a few asks in the community for a fix. There is an issue in the react-360 issues as well.
Here, a stackoverflow issue that I answered today.
Test Plan (required)
All unit tests passed.
Up and run the sample, then, go to
http://localhost:8081/index.htmland check the correct panels' behavior.