Fix bug for Renamed imported object if it has the same name as module #91#166
Conversation
…ed test to prevent future issues
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
This PR fixes an issue where using '.rename()' on a module name would also rename the imported object.
Before:
from commonmark.main import commonmark -> from testme.main import testme
After fix:
from commonmark.main import commonmark -> from testme.main import commonmark
Also includes a test to ensure this bug does not occur again.