fix(parser): Use milliseconds when creating literals of type INTERVAL_DAY_TIME#850
Open
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
Open
fix(parser): Use milliseconds when creating literals of type INTERVAL_DAY_TIME#850mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
mbasmanova wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
…_DAY_TIME
Summary:
INTERVAL '1' DAY was incorrectly parsed into 86400 integer. Since INTERVAL_DAY_TIME type values store milliseconds, the correct value is 86'400'000.
Fixes queries like
> VALUES sequence(from_iso8601_date('2020-01-01'), date('2024-09-30'), INTERVAL '1' DAY)
Differential Revision: D92179225
meta-cla
bot
added
the
CLA Signed
|
@mbasmanova has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92179225. |
amitkdutta
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INTERVAL '1' DAY was incorrectly parsed as the integer 86400. Since INTERVAL_DAY_TIME values are stored in milliseconds, the correct value is 86,400,000.
Fixes queries such as:
Differential Revision: D92179225