feat: Add checked_element_at for Spark ANSI mode array/map access#16359
Open
n0r0shi wants to merge 1 commit intofacebookincubator:mainfrom
Open
feat: Add checked_element_at for Spark ANSI mode array/map access#16359n0r0shi wants to merge 1 commit intofacebookincubator:mainfrom
n0r0shi wants to merge 1 commit intofacebookincubator:mainfrom
Conversation
✅ Deploy Preview for meta-velox canceled.
|
Add checked_element_at that throws on array out-of-bounds access and missing map keys, instead of returning null. For Spark ANSI mode support.
d788767 to
42df6bc
Compare
Author
|
Added a doc. Ready for a review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
checked_element_atthat throws on array out-of-bounds access and missingmap keys, instead of returning null. This matches Spark's ANSI mode behavior
where
ElementAtwithfailOnError=trueraises exceptions.Reuses the existing
SubscriptImpltemplate withallowOutOfBound=falseandthrowOnMissingMapKey=true. Both error paths supportTRY()wrapping.Test plan
TRY()returns nullTRY()returns nullCloses #16358