Explore folders feature #55
Open
david-wagih wants to merge 15 commits intofacebookresearch:seamlistenfrom
Open
Explore folders feature #55david-wagih wants to merge 15 commits intofacebookresearch:seamlistenfrom
david-wagih wants to merge 15 commits intofacebookresearch:seamlistenfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Author
Mortimerp9
reviewed
Aug 22, 2023
Mortimerp9
reviewed
Aug 22, 2023
Mortimerp9
reviewed
Aug 22, 2023
Mortimerp9
suggested changes
Aug 29, 2023
Contributor
Mortimerp9
left a comment
Mortimerp9
left a comment
There was a problem hiding this comment.
some changes on the python code
Co-authored-by: Pierre Andrews <628467+Mortimerp9@users.noreply.github.com>
Mortimerp9
suggested changes
Sep 5, 2023
david-wagih
changed the title
Author
this is a screenshot showing the Tree View in action. |
Mortimerp9
reviewed
Sep 7, 2023
Mortimerp9
reviewed
Sep 7, 2023
Mortimerp9
reviewed
Sep 7, 2023
| print(query_path.split(" ")) | ||
| if query_path.endswith(".tsv.gz") or query_path.endswith(".zip"): | ||
| query_path_str = query.gz_path.strip() | ||
| query_path = Path(query_path_str).expanduser().resolve() |
Contributor
There was a problem hiding this comment.
will this work when the path is one of the other formats (which are not paths?), like:
a/b/c 100 10000
a/b/c|0|231231
Co-authored-by: Pierre Andrews <628467+Mortimerp9@users.noreply.github.com>
Co-authored-by: Pierre Andrews <628467+Mortimerp9@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why ?
We need to have this feature in order to be able to explore all folders and sub folders we need to scan to look for audio files on our seamlisten tool easily (like a JupyterNotebook)
How ?
I have build a method to gather the folder contents given the parent folder path using os.walk() method to do that effectively, and return all the folder contents in an array well constructed.
and this endpoint is called whenver the path the user enters is a path to a directory not a normal file.
Test plan
when running the frontend and the backend successfully, paste in the field to fetch a path to a folder and when pressing fetch, if you opened the console you should see an array of folder contents shown correctly.