feat(locale): add Japanese cat breed definitions#3716
Draft
atzzCokeK wants to merge 2 commits intofaker-js:nextfrom
Draft
feat(locale): add Japanese cat breed definitions#3716atzzCokeK wants to merge 2 commits intofaker-js:nextfrom
atzzCokeK wants to merge 2 commits intofaker-js:nextfrom
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3716 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 3014 3016 +2
Lines 236624 236673 +49
Branches 952 951 -1
=======================================
+ Hits 236566 236615 +49
Misses 58 58
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add cat breed definitions for the Japanese (ja) locale.
This enables
faker.animal.cat()to generate Japanese cat breed names.Added files
cat.ts - Cat breeds (40 items)
Japanese cats (日本猫)
Popular breeds in Japan
References
Test plan
pnpm run generate:localesexecuted successfullypnpm run preflightpassed