✨ Add --reload-dir option

[JoelYoung01]

Added the ability to pass reload-dir option to uvicorn run command.

[JoelYoung01]

Looks like I can't add labels. Figured maybe the autolabeler read the emojis lol, that would be neat.

Everything else should be fine, just need a label to be added.

[07pepa]

thats not it #36 i even tried to fix auto labeler.. with no luck

[JoelYoung01]

Womp womp for us I guess haha.

Guessing @tiangolo has to add labels himself (or anyone with accesss I suppose)

[jordan-vastag]

Just wanna say it'd be awesome if this got merged in! I was thinking about writing a PR to do exactly this, then I saw it was already done :)

[JoelYoung01]

Revisiting this PR to see if anything has changed.

Just to make sure I'm not blind or something I tried adding labels via the gh cli, got this error:

gh pr edit 160 --add-label feature
GraphQL: JoelYoung01 does not have the correct permissions to execute `AddLabelsToLabelable` (addLabelsToLabelable)

Would love to see this merged!

[s-bose]

This is really needed. Would be great if this could be merged!

[YuriiMotov]

LGTM!

Should we also add --reload-delay, --reload-include, and --reload-exclude options?
https://uvicorn.dev/settings/#development

[JoelYoung01]

Sure! I can do that in a couple hours when I am back home, if you want! Or you can just send it too!

[YuriiMotov]

Let's wait for Sebastian to review this.
Meanwhile, community feedback about whether we need --reload-delay, --reload-include, and --reload-exclude is welcome

[almarklein]

--reload-include would be awesome for when you're also serving some html/js/css files.

[numeraltwo]

Can confirm parity with uvicorn on at least --reload-include as well would be useful and likely help fastapi CLI adoption.

The default reload behavior only reloads when *.py files change but a very common local development use case is to reload when a .env changes, e.g. —

fastapi dev --reload-include ".env"

Happy to open a PR for this 👍

[svlandeg]

It looks like this functionality has been added by #267, so I think we can go ahead and close this one. Thanks all for the effort and contributions!

[JoelYoung01]

Noice!!