Clear audio buffer after seeking in a song.#17
Open
jochenrill wants to merge 1 commit intofastbootmobile:masterfrom
Open
Clear audio buffer after seeking in a song.#17jochenrill wants to merge 1 commit intofastbootmobile:masterfrom
jochenrill wants to merge 1 commit intofastbootmobile:masterfrom
Conversation
It creates a weird and unintuitive experience if the song continues to play for a few seconds from the old position after the user already skipped forward to a new position.
Contributor
|
I'm going to look into this - remember there's a delay between flushing the samples and actually getting them. Providers might have the data cached, or it could be pending inside sound effects buffer queues. The best would be to patch the providers (Spotify does it, Localprovider would need to be patched) so that they send an empty buffer after seek, which causes a flush in the NativeSink. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It creates a weird and unintuitive experience if the song continues
to play for a few seconds from the old position after the user already skipped forward to a new position.