Fix importing matplotlib whitch is not in pyproject.toml#70
Open
kazuki wants to merge 1 commit intofastlib:mainfrom
Open
Fix importing matplotlib whitch is not in pyproject.toml#70kazuki wants to merge 1 commit intofastlib:mainfrom
kazuki wants to merge 1 commit intofastlib:mainfrom
Conversation
e45d228 to
39983bb
Compare
Author
|
resolved the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matplotlibis not in dependencies at pyproject.toml.But importing fCWT raises import error.
In this PR, I changed the location of matplotlib import from the top level to inside a function.
This will ensure that matplotlib is imported only when plot is called.