Skip to content

FR-613 Add Rails 7.2 support#24

Merged
etagwerker merged 3 commits intomainfrom
add-support-for-rails-7-2
Feb 10, 2025
Merged

FR-613 Add Rails 7.2 support#24
etagwerker merged 3 commits intomainfrom
add-support-for-rails-7-2

Conversation

@aisayo
Copy link
Contributor

@aisayo aisayo commented Jan 23, 2025

Our main goal is to add the following:

  • Add Rails 7.1 support

Additionally, because we have time:

  • Fixed the test suite configuration
  • Add the CI workflow

Fixes #23

@aisayo aisayo force-pushed the add-support-for-rails-7-2 branch 2 times, most recently from a5b7554 to d063b91 Compare January 23, 2025 21:44
@JuanVqz JuanVqz force-pushed the add-support-for-rails-7-2 branch from d063b91 to 58b4a9b Compare February 5, 2025 16:01
@JuanVqz
Copy link
Member

JuanVqz commented Feb 5, 2025

Let's make sure we read the device upgrade guide

@JuanVqz JuanVqz force-pushed the add-support-for-rails-7-2 branch 3 times, most recently from be3f2ca to 4dbd925 Compare February 5, 2025 17:11
@JuanVqz JuanVqz changed the title update devise support FR-613 Add Rails 7.2 support Feb 5, 2025
@JuanVqz JuanVqz force-pushed the add-support-for-rails-7-2 branch from 4dbd925 to 1c55263 Compare February 5, 2025 17:16
we should be able to run the test suite without issues,

Adding a CI workflows to ensure it is working.

Ticket: https://ombulabs.atlassian.net/browse/FR-613
@JuanVqz JuanVqz force-pushed the add-support-for-rails-7-2 branch from 1c55263 to f8c9652 Compare February 7, 2025 20:22
Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aisayo @JuanVqz Looks good to me 👍🏼

@etagwerker etagwerker merged commit 92d204c into main Feb 10, 2025
3 checks passed
@etagwerker etagwerker deleted the add-support-for-rails-7-2 branch February 10, 2025 14:18
@JuanVqz
Copy link
Member

JuanVqz commented Feb 10, 2025

@etagwerker I can release it, if you provide enough permissions to my RubyGems account 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatible with Rails 7.2? ArgumentError: missing keyword: :deprecator

3 participants