WIP: Update manual setup process by bkmgit · Pull Request #124 · fedora-infra/nuancier

bkmgit · 2019-10-04T08:41:42Z

Add more details on manual setup process.

Replace occurrences of yum with dnf.

cverna

LGTM, just one small comment

README.rst

cverna · 2019-10-04T11:29:29Z

Looks good :-), It would be good to squash the 8 commits into a single one so that you keep a cleaner history. Here is a good guide on how to do that --> https://stackabuse.com/git-squash-multiple-commits-in-to-one-commit/

bkmgit · 2019-10-04T11:35:08Z

Ok - will squash commits. For whatever reason, the build on Python 3.4 seems to fail - though no code changes have been made.

cverna · 2019-10-04T12:00:08Z

Ok - will squash commits. For whatever reason, the build on Python 3.4 seems to fail - though no code changes have been made.

It is ok to ignore, the failure is due to a version conflict for one of the dependency. TBH we should not test on Python 3.4, Python 3.5 and Python 3.6 and target directly Python 3.7

bkmgit · 2019-10-04T12:08:41Z

Added separate pull request, #125 with changed tests.

cverna · 2019-10-04T12:11:48Z

Added separate pull request, #125 with changed tests.

Merged :-)

devel/ansible/roles/nuancier-dev/tasks/main.yml

Vagrantfile.example

jontrossbach · 2020-06-05T19:56:35Z

@bkmgit I just made a PR to your fork. Perhaps, the changes I made should be included in this pull.

jontrossbach

please read my comment in the conversation of this PR

jontrossbach · 2020-06-09T18:26:58Z

@bkmgit I think the changes you made on top of my changes broke the dev-env set up. It appears that Fedora 32 no longer has an rpm named rpm-python and it is breaking the Ansible playbook that is run from the Vagrantfile. Could you try setting up a dev-env on your machine an telling me if you run into the same issue?

jontrossbach

As far as I can tell, this branch is ready to be pulled in now.

pypingou · 2020-06-22T13:30:07Z

The commit history for this PR needs to be cleaned up a little bit before we merge it. The PR needs to be rebased and the commits that belong together be squashed.

README.rst

pypingou · 2020-06-22T13:33:24Z

So 2 comments to address and once this is done and the history cleaned up a little, I think this can get in :)

bkmgit · 2020-07-01T16:41:52Z

@pypingou Squashed commits and addressed the 2 comments. Hopefully ok to merge this pull request.

Started on using OIDC in another branch:
https://github.com/bkmgit/nuancier/tree/newauth
changes in
https://github.com/bkmgit/nuancier/blob/newauth/nuancier/__init__.py

pypingou · 2020-07-02T07:39:23Z

@bkmgit I'm seeing 33 commits in this PR and it looks like the branch is now conflicting, so I think there is still some work to do ;-)

pypingou · 2020-07-02T07:40:39Z

.travis.yml

- - "3.4"
- - "3.5"
- - "3.6"
+ - "3.7"


Why removing the old py3 version? Are we making any changes here that bump the minimum version of python required? (Cf also the minimum version set in the README below).

@pypingou Thanks for the feedback. Using python 3.7 as per suggestion by CVerna.

Previously, the ``WTF_CSRF_TIME_LIMIT`` setting was not in the default configuration, nor was it documented. It also only worked in flask-wtf-0.10.1+, which is not available in EPEL7. This makes it both work in EPEL7's version (0.8) and documents the setting. fixes fedora-infra#78 Signed-off-by: Jeremy Cline <jeremy@jcline.org>

Signed-off-by: Jeremy Cline <jeremy@jcline.org>

Depending on how the tests were run, the test for the pictures endpoint would fail because the path to the pictures folder would be incorrectly calculated since it could be relative. This ensures the path is always absolute. Signed-off-by: Jeremy Cline <jeremy@jcline.org>

I very briefly fiddled with running the tests on 2.6, but decided it wasn't worth the effort. However, I neglected to add the modified .travis.yml file when I updated fedora-infra#108 so this fixes that. Signed-off-by: Jeremy Cline <jeremy@jcline.org>

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Included the tests Make the tests against 3.4 and 3.5 not allowed to fail anymore Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

This will allow to plan some time between the end of the submission phase and the start of the voting phase. Add an alembic migration script to add the submission_date_end field

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Python 3 treats old style exceptions as syntax errors but new style exceptions work as expected in both Python 2 and Python 3.

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

… statement Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

…ute. Update README.rst Remove broken link to image that was at .. image:: http://shieldkins.elrod.me/fedora/nuancier Update README.rst Add git to things to install Update development.rst Update development.rst Change yum to dnf Update deployment.rst Change yum to dnf, however not clear which system wide repositories nuancier is in. Update README.rst Update manual install directions Update README.rst improve formatting Update README.rst formatting fixes, update information on requirements Update README.rst Co-Authored-By: Clement Verna <cverna@users.noreply.github.com> Update development.rst Update development.rst Change yum to dnf Update deployment.rst Change yum to dnf, however not clear which system wide repositories nuancier is in. Update Vagrantfile.example Use Fedora 30 image instead of Fedora 25 Update main.yml Use Python3 Update to use loop syntax Update Vagrantfile.example Remove , sshfs_opts_append: "-o nonempty" since the nonempty option is no longer available. Update Vagrantfile.example Use Python3 in Vagrant example file

Change print statement to be compatible with Python 3

update test requirements remove Python2 from rpm dependencies change dependency from rpm-python to python3-rpm update travis ci file to use only python 3.7 Update Vagrantfile.example Use Fedora 32 image instead of Fedora 25 change dependency from rpm-python to python3-rpm update test requirements remove Python2 from rpm dependencies change dependency from rpm-python to python3-rpm update travis ci file to use only python 3.7 Update Vagrantfile.example Use Fedora 32 image instead of Fedora 25 Update README.rst Remove broken link to image that was at .. image:: http://shieldkins.elrod.me/fedora/nuancier Update README.rst Add git to things to install Update development.rst Update development.rst Change yum to dnf Update deployment.rst Change yum to dnf, however not clear which system wide repositories nuancier is in. Update README.rst Update manual install directions Update README.rst improve formatting Update README.rst formatting fixes, update information on requirements Update README.rst Co-Authored-By: Clement Verna <cverna@users.noreply.github.com> Update development.rst Update development.rst Change yum to dnf Update deployment.rst Change yum to dnf, however not clear which system wide repositories nuancier is in. Update Vagrantfile.example Remove , sshfs_opts_append: "-o nonempty" since the nonempty option is no longer available. Fedora 32 no longer supports rpm-python, updated to python3-rpm which seems to cover everything rpm-python was doing

cverna reviewed Oct 4, 2019

View reviewed changes

README.rst Outdated Show resolved Hide resolved

pypingou force-pushed the master branch from 76de428 to 8a62363 Compare November 6, 2019 22:02

sebwoj reviewed Nov 7, 2019

View reviewed changes

devel/ansible/roles/nuancier-dev/tasks/main.yml Show resolved Hide resolved

sebwoj reviewed Nov 7, 2019

View reviewed changes

devel/ansible/roles/nuancier-dev/tasks/main.yml Show resolved Hide resolved

sebwoj suggested changes Nov 7, 2019

View reviewed changes

devel/ansible/roles/nuancier-dev/tasks/main.yml Show resolved Hide resolved

Vagrantfile.example Outdated Show resolved Hide resolved

bkmgit changed the title ~~Update manual setup process~~ WIP: Update manual setup process Nov 10, 2019

jontrossbach suggested changes Jun 5, 2020

View reviewed changes

jontrossbach mentioned this pull request Jun 10, 2020

[WIP] Port nuancier to fedora-messaging #127

Open

jontrossbach approved these changes Jun 16, 2020

View reviewed changes

jontrossbach mentioned this pull request Jun 16, 2020

test cases now passing that previously failed sebwoj/nuancier#1

Open

pypingou reviewed Jun 22, 2020

View reviewed changes

README.rst Show resolved Hide resolved

pypingou reviewed Jun 22, 2020

View reviewed changes

README.rst Show resolved Hide resolved

pypingou reviewed Jul 2, 2020

View reviewed changes

pypingou and others added 6 commits July 2, 2020 11:44

Encode the image title to UTF-8 for non-ascii characters

415cf6d

Clarify the CSRF documentation in default_config

d127753

Signed-off-by: Jeremy Cline <jeremy@jcline.org>

Add a Vagrant environment

53a8da8

Signed-off-by: Jeremy Cline <jeremy@jcline.org>

pypingou and others added 26 commits July 2, 2020 11:44

Fix import error due to recent changes in flask

f10cd6f

Fix the minimal flask-wtf version not working as expected

b7f621e

Small style changes

3366487

Include the coverage as the dependency to run the tests

4c89735

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Port nuancier to python3 while remaining compatible with python2

55004f4

Included the tests Make the tests against 3.4 and 3.5 not allowed to fail anymore Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Drop two un-needed instantiators.

f3ef216

Add an submission_date_end field to the Election

c486303

This will allow to plan some time between the end of the submission phase and the start of the voting phase. Add an alembic migration script to add the submission_date_end field

Improve the MANIFEST.in to exclude some un-necessary files

cc6a908

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Release 0.11.0

fc114ec

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Gets 'vagrant up' to work from fresh git clone

0d37155

Old style exceptions --> new style in Python 3

3168d10

Python 3 treats old style exceptions as syntax errors but new style exceptions work as expected in both Python 2 and Python 3.

Clean up a little bit deprecated code

bc23f72

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Add support for tox to run the tests

676d0eb

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Add .cico.pipeline file

94ee41b

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Pass onto tox the HOME variable

a78b047

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Adjust a little bit travis and tox to test more

4eebe4f

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Run tox in verbose mode

8524789

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Make travis call nose in verbose mode

608e888

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Make nuancier's code forward compatible with new version of flask-wtf

48ca0ef

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Make it explicit that 'votes DESC' is a text representation of an SQL…

aa62560

… statement Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Make the tests pass with newer version that return 308 instead of 301

331106e

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

Ensure the order remains consistent

c1a7b96

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

check if picture is landscape oriented

19719aa

Update 7db0e24a2a85_add_submission_end_date.py

23513a1

Change print statement to be compatible with Python 3

bkmgit force-pushed the master branch from 039e71c to 844c42b Compare July 2, 2020 08:52

Conversation

bkmgit commented Oct 4, 2019

Uh oh!

cverna left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cverna commented Oct 4, 2019

Uh oh!

bkmgit commented Oct 4, 2019

Uh oh!

cverna commented Oct 4, 2019

Uh oh!

bkmgit commented Oct 4, 2019

Uh oh!

cverna commented Oct 4, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jontrossbach commented Jun 5, 2020

Uh oh!

jontrossbach left a comment

Choose a reason for hiding this comment

Uh oh!

jontrossbach commented Jun 9, 2020

Uh oh!

jontrossbach left a comment

Choose a reason for hiding this comment

Uh oh!

pypingou commented Jun 22, 2020

Uh oh!

Uh oh!

Uh oh!

pypingou commented Jun 22, 2020

Uh oh!

bkmgit commented Jul 1, 2020

Uh oh!

pypingou commented Jul 2, 2020

Uh oh!

pypingou Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

bkmgit Jul 2, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants