[WIP] Sharing fedoralovespython on social media#31
[WIP] Sharing fedoralovespython on social media#31nmilosev wants to merge 3 commits intofedora-python:masterfrom
Conversation
|
TODO: check the description please |
|
Twitter:
Facebook:
Ignore the IP address, that was my testing DO droplet. |
Enable pretty Twitter and FB formatting. Add new image for sharing (fedoralovespython-share.jpg) only JPEG images are allowed Add metadata for FB and twitter validated with https://cards-dev.twitter.com/validator (Twitter) and https://developers.facebook.com/tools/debug/og/object/ Facebook validator shows some warnings which can be ignored: http://stackoverflow.com/questions/16475336/open-graph-twitter-cards-html5-incompatible Related issue: fedora-python#25
|
I'd suggest smaller margin in the image. Like this (don't use this one, it's not cropped with any precision).
|
- smaller margins
Done. Twitter screenshot:
Facebook still has old one cached, will update asap. Can squash into one commit. |
|
Could you plese do a deploy as described in https://github.com/fedora-python/fedoralovespython.org#hacking ? If there is anything unclear about it, ask and I'll update the instructions. |
templates/index.html
Outdated
| <!-- For Facebook and Twitter: --> | ||
| <meta property="og:type" content="article"> | ||
| <meta property="og:title" content="Fedora Loves Python - fedoralovespython.org"> | ||
| <meta property="og:description" content="Fedora’s relationship with Python is very close, making it probably the best platform for developing with Python - learn why!"> |
There was a problem hiding this comment.
I'd drop the probably - let us brag a little.
templates/index.html
Outdated
| <link href='https://fonts.googleapis.com/css?family=Open+Sans:400,400italic,600,600italic&subset=latin' rel='stylesheet' type='text/css'> | ||
| <!-- For Facebook and Twitter: --> | ||
| <meta property="og:type" content="article"> | ||
| <meta property="og:title" content="Fedora Loves Python - fedoralovespython.org"> |
| <meta property="og:type" content="article"> | ||
| <meta property="og:title" content="Fedora Loves Python - fedoralovespython.org"> | ||
| <meta property="og:description" content="Fedora’s relationship with Python is very close, making it probably the best platform for developing with Python - learn why!"> | ||
| <meta property="og:url" content="https://fedoralovespython.org/"> |
There was a problem hiding this comment.
Shouldn't this be the pages's url? There's also /__future__/
| <meta property="og:type" content="article"> | ||
| <meta property="og:title" content="Fedora Loves Python – fedoralovespython.org"> | ||
| <meta property="og:description" content="Fedora’s relationship with Python is very close, making it the best platform for developing with Python - learn why!"> | ||
| <meta property="og:url" content="https://fedoralovespython.org/"> |
There was a problem hiding this comment.
This shall be with __future__ on the __future__ page
|
@nmilosev what's the status? |
|
I completely forgot about this. :( I think it's pretty complete, just needs a final check from you. That is of course if the API hasn't changed. :D We lost a lost of time trying to setup my GH pages last time, so maybe it's better if you can finish this one off. As far as I can remember the only thing needed doing is changing the hardcoded link in the template. If you need help, please let me know. :) |
2 participants
Enable pretty Twitter and FB formatting.
Add new image for sharing (fedoralovespython-share.jpg)
Add metadata for FB and twitter
https://developers.facebook.com/tools/debug/og/object/
Facebook validator shows some warnings which can be ignored:
Related issue: #25