Skip to content

fixes #437: adding further locales to the image#438

Open
daudo wants to merge 1 commit intofelddy:developfrom
daudo:fix-issue-437
Open

fixes #437: adding further locales to the image#438
daudo wants to merge 1 commit intofelddy:developfrom
daudo:fix-issue-437

Conversation

@daudo
Copy link

@daudo daudo commented Aug 10, 2025

🗣 Description

This patch enables WeeWX Docker containers to properly support international skins and extensions that rely on system locales for date/time formatting and translations. Currently, many skins and extensions (ie. the Belchertown skin) fail to display localized content because the required locales aren't available in the base image.

The change is minimal, and will probably useful for for international WeeWX users without any negative impact on existing deployments.

💭 Motivation and context

Give more flexibility for international users, fixes #437

🧪 Testing

I tested the changes by running locale -a in a running container. And also, the Belchertown skin worked flawlessly after adding the locales. And apart from that, those changes are trivial.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Add a tag or create a release.

@daudo daudo requested a review from felddy as a code owner August 10, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add other locales than C

1 participant