fixes #437: adding further locales to the image#438
Open
daudo wants to merge 1 commit intofelddy:developfrom
Open
fixes #437: adding further locales to the image#438daudo wants to merge 1 commit intofelddy:developfrom
daudo wants to merge 1 commit intofelddy:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This patch enables WeeWX Docker containers to properly support international skins and extensions that rely on system locales for date/time formatting and translations. Currently, many skins and extensions (ie. the Belchertown skin) fail to display localized content because the required locales aren't available in the base image.
The change is minimal, and will probably useful for for international WeeWX users without any negative impact on existing deployments.
💭 Motivation and context
Give more flexibility for international users, fixes #437
🧪 Testing
I tested the changes by running locale -a in a running container. And also, the Belchertown skin worked flawlessly after adding the locales. And apart from that, those changes are trivial.
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist