Skip to content

Modernize (Babel 7 + Hooks)#17

Open
jadbox wants to merge 7 commits intofelippenardi:masterfrom
jadbox:modernize
Open

Modernize (Babel 7 + Hooks)#17
jadbox wants to merge 7 commits intofelippenardi:masterfrom
jadbox:modernize

Conversation

@jadbox
Copy link

@jadbox jadbox commented Mar 26, 2019

This is a quick effort to rewrite with Hooks and updated Babel v7.
I've currently published this under @jadbox/lottie-react-web for testing.

THIS IS NOT ready to be merged yet... very quirks still be working on.

Edit: branch ready for merge

@jadbox
Copy link
Author

jadbox commented Mar 26, 2019

My branch seems to be working for my project as well as all the storybook examples, however I can't seem to get the test suite running:

Warning: ReactTestUtils has been moved to react-dom/test-utils. Update references to remove this warning.
/home/jdunlap/plus/github/jadbox/lottie-react-web/node_modules/enzyme/build/react-compat.js:144
      throw new Error('react-addons-test-utils is an implicit dependency in order to support react@0.13-14. ' + 'Please add the appropriate version to your devDependencies. ' + 'See https://github.com/airbnb/enzyme#installation');
      ^

Error: react-addons-test-utils is an implicit dependency in order to support react@0.13-14. Please add the appropriate version to your devDependencies. See https://github.com/airbnb/enzyme#installation
    at Object.<anonymous> (/home/jdunlap/plus/github/jadbox/lottie-react-web/node_modules/enzyme/build/react-compat.js:144:13)
    at Module._compile (internal/modules/cjs/loader.js:701:30)
    at Module._compile (/home/jdunlap/plus/github/jadbox/lottie-react-web/node_modules/pirates/lib/index.js:99:24)
    at Module._extensions..js (internal/modules/cjs/loader.js:712:10)
    at Object.newLoader [as .js] (/home/jdunlap/plus/github/jadbox/lottie-react-web/node_modules/pirates/lib/index.js:104:7)
    at Module.load (internal/modules/cjs/loader.js:600:32)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant