feat(cli): add page-size configuration option for changelog pagination#12061
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
feat(cli): add page-size configuration option for changelog pagination#12061devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
Co-Authored-By: Catherine Deskur <catherine@buildwithfern.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Catherine Deskur <catherine@buildwithfern.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #12006
Adds a
page-sizeconfiguration option for changelog navigation items indocs.yml. This allows users to control how many changelog entries are displayed per page.Companion PR: https://github.com/fern-api/fern-platform/pull/6837 (adds
pageSizeto FDRChangelogNodetype)Changes Made
page-sizeproperty toChangelogConfigurationin the docs.yml schemaParsedDocsConfigurationto includepageSizeon changelog itemsparseDocsConfiguration.tsto parse the new propertyChangelogNodeConverterto passpageSizethrough to the FDR nodeDocsDefinitionResolverto passpageSizewhen creating changelog nodesExample Usage
Testing
pnpm run check)Human Review Checklist
page-size→pageSizeproperty mapping is correct in serializationpageSizeis only supported onchangelognavigation items, not on tabbed changelog tabs (this is intentional based on the schema)Link to Devin run: https://app.devin.ai/sessions/9f9efc959e4a4fbfba758b6926a201f1
Requested by: Catherine Deskur