feat(java): implement URI and path-based pagination#12324
Open
feat(java): implement URI and path-based pagination#12324
Conversation
Adds visitUri and visitPath implementations to the three Pagination.Visitor sites in AbstractHttpResponseParserGenerator, supporting the new IR v64 UriPagination and PathPagination types. Also bumps IR dependency from v63 to v64. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
🌱 Seed Test SelectorSelect languages to run seed tests for:
How to use: Click the ⋯ menu above → "Edit" → check the boxes you want → click "Update comment". Tests will run automatically and snapshots will be committed to this PR. |
Adds visitUri and visitPath implementations to the three Pagination.Visitor sites in AbstractHttpResponseParserGenerator, supporting the new IR v65 UriPagination and PathPagination types. Also bumps IR dependency from v63 to v64 and updates seed.yml to target IR v65. Changes: - Implement URI/path pagination in ClassName, TypeName, and response parsing visitors - Handle endpoints with no request parameter spec (URI/path pagination is response-driven) - Add new version entry (3.36.0) in sdk/versions.yml with irVersion 65 - Register Java SDK 3.36.0 in v65-to-v63 migration - Update seed/java-sdk/seed.yml to irVersion v65 - Update pagination-uri-path seed fixture output Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…d fixture Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tjb9dc
changed the title
tjb9dc
force-pushed
the
tb/java-uri-path-pagination
branch
from
f8e29eb to
33578e8
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
…lude pagination files - Add UriPage.java and PathPage.java template resources for URI/path pagination - Rewrite visitUriOrPathPagination to generate UriPage.create()/PathPage.create() calls instead of inline AtomicReference lambda pattern - Conditionally include UriPage, PathPage, CustomPager, AsyncCustomPager, and BiDirectionalPage only when the IR has endpoints using those pagination types - Pass exception class names to PaginationCoreGenerator for proper error handling in generated pagination utilities Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tjb9dc
force-pushed
the
tb/java-uri-path-pagination
branch
from
33578e8 to
ff9223b
Compare
Resolve conflicts in versions.yml (bump our entry to 3.37.0), versions.props and versions.lock (keep irV64 needed for URI/path pagination). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visitUriandvisitPathmethods across all threePagination.Visitorsites inAbstractHttpResponseParserGeneratorUriPaginationandPathPaginationtypesTest plan
./gradlew compileJavapasses successfully🤖 Generated with Claude Code