Skip to content

pdpv0: Settle watcher doesn't block on fwss railToDataSet errors#961

Merged
rjan90 merged 1 commit intopdpv0from
fix/settle-failures
Feb 12, 2026
Merged

pdpv0: Settle watcher doesn't block on fwss railToDataSet errors#961
rjan90 merged 1 commit intopdpv0from
fix/settle-failures

Conversation

@ZenGround0
Copy link
Collaborator

Closes #922

This is a strange one because the rail to dataset mapping should

  1. Never fail with a revert
  2. Never fail with empty value until dataset is deleted which should ONLY be possible after we have processed settlement in the watcher

So in short I have no idea how we are in this state. But there is probably no reason to be stopping the world if we get in such a bad state.

@TippyFlitsUK it would be very helpful to see the railIds in your new log so I can try to understand what is going on with fwss contract to cause such errors in the first place. But I hope that after merging this your watcher will only log the error once and then move on.

@ZenGround0 ZenGround0 changed the title Throw up out hands when fwss acts stupid Settle watcher doesn't block on fwss railToDataSet errors Feb 10, 2026
@ZenGround0 ZenGround0 requested review from LexLuthr and rvagg February 10, 2026 22:48
@ZenGround0 ZenGround0 changed the title Settle watcher doesn't block on fwss railToDataSet errors pdpv0: Settle watcher doesn't block on fwss railToDataSet errors Feb 10, 2026
@github-actions github-actions bot added the team/fs-wg Items being worked on or tracked by the "FS Working Group". See FilOzone/github-mgmt #10 label Feb 10, 2026
@rjan90
Copy link
Collaborator

rjan90 commented Feb 11, 2026

@ZenGround0 Beck also posted some RailIDs he is seeing here: #922 (comment)

@TippyFlitsUK
Copy link
Contributor

TippyFlitsUK commented Feb 11, 2026

BEFORE node update to fix/settle-failures

calib.ezpdpz.net - LOGS

"SELECT COUNT(*) FROM curio.filecoin_payment_transactions fpt JOIN curio.message_waits_eth mwe ON fpt.tx_hash = mwe.signed_tx_hash WHERE mwe.tx_status = 'confirmed' AND mwe.tx_success = TRUE;"
 count 
-------
   182
(1 row)

calib2.ezpdpz.net - LOGS

"SELECT COUNT(*) FROM curio.filecoin_payment_transactions fpt JOIN curio.message_waits_eth mwe ON fpt.tx_hash = mwe.signed_tx_hash WHERE mwe.tx_status = 'confirmed' AND mwe.tx_success = TRUE;"
 count 
-------
   262
(1 row)

main.ezpdpz.net - LOGS

"SELECT COUNT(*) FROM curio.filecoin_payment_transactions fpt JOIN curio.message_waits_eth mwe ON fpt.tx_hash = mwe.signed_tx_hash WHERE mwe.tx_status = 'confirmed' AND mwe.tx_success = TRUE;"
 count 
-------
     5
(1 row)

@BigLep BigLep added this to FOC Feb 11, 2026
@BigLep BigLep moved this to 🔎 Awaiting review in FOC Feb 11, 2026
@TippyFlitsUK
Copy link
Contributor

POST 961 node update

Looking good! No new instances of the error occurring on any of the 3 nodes using:

tail -f /var/log/curio/curio.log|grep "failed to verify settle"

calib.ezpdpz.net - calib_961.log

SELECT COUNT(*) FROM curio.filecoin_payment_transactions fpt JOIN curio.message_waits_eth mwe ON fpt.tx_hash = mwe.signed_tx_hash WHERE mwe.tx_status = 'confirmed' AND mwe.tx_success = TRUE;"
 count 
-------
     0
(1 row)

calib2.ezpdpz.net - calib2_961.log

"SELECT COUNT(*) FROM curio.filecoin_payment_transactions fpt JOIN curio.message_waits_eth mwe ON fpt.tx_hash = mwe.signed_tx_hash WHERE mwe.tx_status = 'confirmed' AND mwe.tx_success = TRUE;"
  
 count 
-------
     0
(1 row)

main.ezpdpz.net - main_961.log

"SELECT COUNT(*) FROM curio.filecoin_payment_transactions fpt JOIN curio.message_waits_eth mwe ON fpt.tx_hash = mwe.signed_tx_hash WHERE mwe.tx_status = 'confirmed' AND mwe.tx_success = TRUE;"
 count 
-------
     0
(1 row)

@github-project-automation github-project-automation bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Feb 12, 2026
@rjan90 rjan90 merged commit 9a32b94 into pdpv0 Feb 12, 2026
18 checks passed
@rjan90 rjan90 deleted the fix/settle-failures branch February 12, 2026 08:18
@github-project-automation github-project-automation bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Feb 12, 2026
@rvagg
Copy link
Member

rvagg commented Feb 12, 2026

I started reviewing this, put it down for a while, came back and it was merged. But that exercise resulted in this: #973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team/fs-wg Items being worked on or tracked by the "FS Working Group". See FilOzone/github-mgmt #10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pdpv0: stuck settlement transactions after confirmed on-chain but failed DB update

5 participants