250: adding a temporary change in reminderController#459
Open
kapirath28 wants to merge 1 commit intofinos:spring-bot-masterfrom
Open
250: adding a temporary change in reminderController#459kapirath28 wants to merge 1 commit intofinos:spring-bot-masterfrom
kapirath28 wants to merge 1 commit intofinos:spring-bot-masterfrom
Conversation
|
Author
|
its my first contribution just tried to fix the issue 250 |
Member
|
Hi @kapirath28, Thanks for this - why did you close it? I think you were on the right track. Just looking at the Reminder Bot with @vaibhav-db , we think the "check it's in the future" code should be in this class: Do you want to have another try? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
its my first contribution just tried to fix the issue by
-In the addreminder method, before adding a new reminder, ichecked if the Reminder has a valid time in the future.
-removed reminders from the list that have a localTime before the current time (LocalDateTime.now())
(i am a beginner at this let me know about it.)