Conversation
Summary of ChangesHello @yesudeep, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request introduces a robust authentication mechanism for CI workflows and a helpful bootstrapping script for tags. The auth job logic in releasekit-uv.yml is well-implemented for identity resolution, but this logic is not fully utilized in the subsequent jobs, and other workflows use a simplified version that lacks identity resolution. Additionally, the bootstrap_tags.py script uses a risky git push --tags command which should be scoped to the relevant workspace tags to avoid unintended side effects in a monorepo environment.
b89a4db to
b432dcc
Compare
b432dcc to
7e779f0
Compare
Summary
Adds CI authentication and bootstrap infrastructure for the releasekit release pipeline.
Auth job (3-tier: App → PAT → GITHUB_TOKEN)
All 8 release workflows (1 live + 7 sample templates) now include an
authjob with:Each mode resolves git identity (user name + email) for commit attribution:
<app-slug>[bot]identity with API-fetched user IDRELEASEKIT_GIT_USER_NAME/RELEASEKIT_GIT_USER_EMAILrepo variables (falls back toreleasekit[bot])github-actions[bot])This means CLA checks can pass even with GITHUB_TOKEN by setting repo variables to a CLA-signed identity.
auth_methoddropdownAll workflows now include an
auth_methodchoice in the workflow dispatch UI:autoapppatgithub-tokenBootstrap tags
bootstrap_tags.py— Standalone PEP 723 script that readsreleasekit.toml, discovers all workspace packages usinglibrary_dirs, and creates per-package tags at thebootstrap_shacommitpy/v0.5.0)Code review fixes
RELEASEKIT_GIT_USER_NAME/RELEASEKIT_GIT_USER_EMAILenv vars to prepare and release job stepsgh apicall when fetching App bot user ID (falls back touser_id=0)bootstrap_tags.pynow readslibrary_dirsfromreleasekit.tomlinstead of hardcoding['packages', 'plugins']loggingmodule calls (previously stripped aspassplaceholders for T20 compliance)Documentation
Added to
README.md:auth_methoddropdown reference tableSetup instructions
To configure CLA-passing identity with GITHUB_TOKEN (no App/PAT needed):
https://github.com/firebase/genkit/settings/variables/actionsRELEASEKIT_GIT_USER_NAME= your nameRELEASEKIT_GIT_USER_EMAIL= your CLA-signed emailFollow-up
releasekit initcould auto-create bootstrap tags whenbootstrap_shais set (instead of requiring a separate script)Files changed
.github/workflows/releasekit-uv.ymlauth_methodpy/tools/releasekit/github/workflows/releasekit-uv.ymlauth_methodpy/tools/releasekit/github/workflows/releasekit-cargo.ymlauth_methodpy/tools/releasekit/github/workflows/releasekit-dart.ymlauth_methodpy/tools/releasekit/github/workflows/releasekit-go.ymlauth_methodpy/tools/releasekit/github/workflows/releasekit-gradle.ymlauth_methodpy/tools/releasekit/github/workflows/releasekit-pnpm.ymlauth_methodpy/tools/releasekit/scripts/bootstrap_tags.pypy/tools/releasekit/README.md