vCPU Hot-unplug #4753
Draft
ghost wants to merge 3 commits intofirecracker-microvm:feature/vcpu-hotplugfrom
Draft
vCPU Hot-unplug #4753ghost wants to merge 3 commits intofirecracker-microvm:feature/vcpu-hotplugfrom
ghost wants to merge 3 commits intofirecracker-microvm:feature/vcpu-hotplugfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (79.21%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## feature/vcpu-hotplug #4753 +/- ##
========================================================
- Coverage 81.95% 79.21% -2.74%
========================================================
Files 257 224 -33
Lines 31762 26485 -5277
========================================================
- Hits 26031 20981 -5050
+ Misses 5731 5504 -227
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Change from `add` to `target`. The user now supplies the number of vCPUs they would like to reach, rather than the number of vCPUs to add to the system. Obviously to make this work, hot-unplug functionality is needed as well. Examples: - Currently 1 vCPU, would like 16 vCPUs: target = 16 - Currently 32 vCPUs, would like 2 vCPUs: target = 2 Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
Guest side hot-unplug implementation. This means that the API call can be made, and the vCPUs are successfully removed from the guest, but the backing vCPU threads are not removed from the host VMM. As a result of this, hot-plugs that occur after hot-unplugs do not work correctly right now. Once the total thread count in the VMM exceeds 32, there is no effect of hot-plugging. To complete this, a refactor is needed of the VMM, such that the CpuContainer can somehow remove the threads when the guest kernel calls _EJ0. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
ghost
Update metrics and swagger to reflect the changes made to the API. Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
JamesC1305
added
the
Status: Parked
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/hotplugendpoint, now the user requests a target number of vCPUs to be reached.Unfinished
CpuContainerthe ability to terminate threads.Reason
To provide the inverse of hot-plugging, so that VMs can be scaled in both directions.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.