Skip to content

sign: adding keyguard authorization for vote txn [wip]#8181

Open
ibhatt-jumptrading wants to merge 4 commits intomainfrom
ibhatt/vote_txn_authorization
Open

sign: adding keyguard authorization for vote txn [wip]#8181
ibhatt-jumptrading wants to merge 4 commits intomainfrom
ibhatt/vote_txn_authorization

Conversation

@ibhatt-jumptrading
Copy link
Contributor

@ibhatt-jumptrading ibhatt-jumptrading commented Feb 5, 2026

fixes #7937

@ibhatt-jumptrading ibhatt-jumptrading added this to the v1.0 milestone Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.070366 s 0.070035 s -0.470%
backtest mainnet-368528500-perf snapshot load NaN s NaN s NaN%
backtest mainnet-368528500-perf total elapsed 70.365792 s 70.034548 s -0.471%
firedancer mem usage with mainnet.toml 1069.34 GiB 1069.34 GiB 0.000%

Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still allows arbitrary transaction signing, can we restrict this to the vote program? And then also prevent destructive actions like closing a vote account?

@ibhatt-jumptrading ibhatt-jumptrading changed the title sign: adding keyguard authorization for vote txn sign: adding keyguard authorization for vote txn [wip] Feb 6, 2026
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Performance Measurements ⏳

Suite Baseline New Change
backtest mainnet-368528500-perf per slot 0.05127 s 0.051529 s 0.505%
backtest mainnet-368528500-perf snapshot load NaN s NaN s NaN%
backtest mainnet-368528500-perf total elapsed 51.270241 s 51.529356 s 0.505%
firedancer mem usage with mainnet.toml 1069.34 GiB 1069.34 GiB 0.000%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vote txn keyguard authorization

2 participants