Open
Conversation
intrigus-lgtm
changed the title
intrigus-lgtm
force-pushed
the
intrigus/fix/xdp-tile-test-uninit
branch
from
d202376 to
3ee2082
Compare
Contributor
|
crazy find |
intrigus-lgtm
force-pushed
the
intrigus/fix/xdp-tile-test-uninit
branch
3 times, most recently
from
090996c to
16989e4
Compare
Performance Measurements ⏳
|
Contributor
Author
|
Sorry for the spam, but MSAN even with optimizations disabled didn't catch that we were comparing an uninitialized padding byte as the struct wasn't packed. |
The during_frag_expected_sz variable was not initialized leading to mismatches in fd_memeq later on. This bug is surprisingly difficult to trigger as neither msan, ubsan nor asan were able to catch the problem. (At least with enabled optimizations)
intrigus-lgtm
force-pushed
the
intrigus/fix/xdp-tile-test-uninit
branch
from
16989e4 to
9d8e69f
Compare
Performance Measurements ⏳
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The during_frag_expected_sz variable was not initialized leading to mismatches in fd_memeq later on. This bug is surprisingly difficult to trigger as neither msan, ubsan nor asan were able to catch the problem. (At least with enabled optimizations)