Merged
Conversation
Open
pbrubeck
force-pushed
the
pbrubeck/bdfm
branch
from
9b46265 to
ef3ac5b
Compare
pbrubeck
commented
Feb 5, 2026
Comment on lines
-28
to
-30
| # codimension 1 facet tangents. | ||
| # because the tangent component is discontinuous, these actually | ||
| # count as internal nodes. |
Author
There was a problem hiding this comment.
These DOFs are bad for interpolation. In particular they do not preserve functions that already live in this space. This is as wrong as using point evaluations at vertices for DG1.
Therefore the point variant is changing to be consistent with the dofs we have for BDM (point evaluations of normal components on faces and integral moments against the Nedelec basis on the interior).
dham
approved these changes
Feb 5, 2026
pbrubeck
force-pushed
the
pbrubeck/bdfm
branch
from
fc469bd to
878490b
Compare
wence-
reviewed
Feb 6, 2026
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
pbrubeck
commented
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.