chore: add install command to all apps/packages and fix lint issues

Author: gracefullight

.gitignore

@@ -44,6 +44,7 @@ coverage/
 .coverage
 htmlcov/
 .pytest_cache/
+.ruff_cache/
 
 # Terraform
 .terraform/

apps/api/mise.toml

@@ -1,9 +1,10 @@
 [tasks]
 dev = { run = "uv run poe dev", description = "Start API server" }
+install = { run = "uv sync", description = "Install dependencies" }
 lint = { run = "uv run poe lint", description = "Lint API" }
 format = { run = "uv run poe format", description = "Format API" }
 test = { run = "uv run poe test", description = "Test API" }
-typecheck = { run = "uv run poe type-check", description = "Type check API" }
+typecheck = { run = "uv run poe typecheck", description = "Type check API" }
 migrate = { run = "uv run poe migrate", description = "Run DB migrations" }
 "migrate:create" = { run = "uv run poe migrate-create", description = "Create migration" }
 "gen:openapi" = { run = "uv run python scripts/gen_openapi.py", description = "Generate OpenAPI schema" }

apps/api/pyproject.toml

@@ -53,10 +53,10 @@ format = "ruff format ."
 check = ["lint", "format"]
 
 # Type checking
-"type-check" = "mypy src"
+typecheck = "mypy src"
 
 # All checks
-"all-checks" = ["check", "type-check"]
+"all-checks" = ["check", "typecheck"]
 
 # Testing
 test = "pytest tests/"
@@ -76,3 +76,7 @@ exclude = ["alembic"]
 [[tool.mypy.overrides]]
 module = ["asyncpg.*"]
 ignore_missing_imports = true
+
+[[tool.mypy.overrides]]
+module = ["redis.asyncio.*"]
+ignore_missing_imports = true

apps/api/src/common/models/pagination.py

@@ -1,11 +1,7 @@
 """Pagination models and utilities."""
 
-from typing import Generic, TypeVar
-
 from pydantic import BaseModel, Field
 
-T = TypeVar("T")
-
 
 class PaginationParams(BaseModel):
     """Query parameters for pagination."""
@@ -30,7 +26,7 @@ class PaginationMeta(BaseModel):
     has_prev: bool = Field(description="Whether there is a previous page")
 
 
-class PaginatedResponse(BaseModel, Generic[T]):  # noqa: UP046
+class PaginatedResponse[T](BaseModel):
     """Generic paginated response wrapper."""
 
     data: list[T]

apps/api/src/lib/ai/base.py

@@ -1,11 +1,9 @@
 from abc import ABC, abstractmethod
 from collections.abc import AsyncIterator
-from typing import Any, Generic, TypeVar
+from typing import Any
 
-T = TypeVar("T")
 
-
-class AIProvider(ABC, Generic[T]):  # noqa: UP046
+class AIProvider[T](ABC):
     @abstractmethod
     async def analyze_image(self, image_data: bytes | list[bytes]) -> T:
         pass

apps/api/src/lib/logging.py

@@ -2,7 +2,7 @@
 
 import logging
 import sys
-from typing import Any
+from typing import Any, cast
 
 import structlog
 from opentelemetry import trace
@@ -72,4 +72,4 @@ def configure_logging() -> None:
 
 def get_logger(name: str | None = None) -> structlog.stdlib.BoundLogger:
     """Get a configured structured logger."""
-    return structlog.get_logger(name)
+    return cast(structlog.stdlib.BoundLogger, structlog.get_logger(name))

apps/api/src/lib/rate_limit.py

@@ -2,14 +2,19 @@
 
 import time
 from collections import defaultdict
-from collections.abc import Callable
+from collections.abc import Awaitable, Callable
 from dataclasses import dataclass, field
+from typing import TYPE_CHECKING, cast
 
 from fastapi import HTTPException, Request, status
+from fastapi.responses import Response
 
 from src.lib.config import settings
 from src.lib.logging import get_logger
 
+if TYPE_CHECKING:
+    import redis.asyncio as redis_module
+
 logger = get_logger(__name__)
 
 
@@ -74,14 +79,17 @@ class RedisRateLimiter:
     def __init__(self, requests: int, window: int):
         self.requests = requests
         self.window = window
-        self._redis = None
+        self._redis: "redis_module.Redis | None" = None
 
-    async def _get_redis(self):
+    async def _get_redis(self) -> "redis_module.Redis":
         """Lazy Redis connection."""
         if self._redis is None:
             import redis.asyncio as redis
 
-            self._redis = redis.from_url(settings.REDIS_URL)
+            self._redis = cast(
+                redis_module.Redis,
+                redis.from_url(settings.REDIS_URL),  # type: ignore[no-untyped-call]
+            )
         return self._redis
 
     async def is_allowed(self, key: str) -> tuple[bool, int, int]:
@@ -114,7 +122,7 @@ async def is_allowed(self, key: str) -> tuple[bool, int, int]:
 
         return True, remaining, reset_after
 
-    async def close(self):
+    async def close(self) -> None:
         """Close Redis connection."""
         if self._redis:
             await self._redis.aclose()
@@ -144,7 +152,7 @@ def rate_limit(
     requests: int = 100,
     window: int = 60,
     key_func: Callable[[Request], str] | None = None,
-):
+) -> Callable[[Callable[..., Awaitable[Response]]], Callable[..., Awaitable[Response]]]:
     """
     Rate limit decorator for FastAPI endpoints.
 
@@ -162,16 +170,18 @@ async def get_resource():
     config = RateLimitConfig(requests=requests, window=window, key_func=key_func)
     actual_key_func = key_func or default_key_func
 
-    def decorator(func):
-        async def wrapper(*args, **kwargs):
+    def decorator(
+        func: Callable[..., Awaitable[Response]],
+    ) -> Callable[..., Awaitable[Response]]:
+        async def wrapper(*args: object, **kwargs: object) -> Response:
             # Find request in args/kwargs
             request: Request | None = None
             for arg in args:
                 if isinstance(arg, Request):
                     request = arg
                     break
             if request is None:
-                request = kwargs.get("request")
+                request = cast(Request | None, kwargs.get("request"))
 
             if request is None:
                 return await func(*args, **kwargs)
@@ -208,8 +218,10 @@ async def wrapper(*args, **kwargs):
 
 
 async def rate_limit_middleware(
-    request: Request, call_next, config: RateLimitConfig | None = None
-):
+    request: Request,
+    call_next: Callable[[Request], Awaitable[Response]],
+    config: RateLimitConfig | None = None,
+) -> Response:
     """
     Rate limit middleware for global application.
 

apps/api/src/lib/telemetry.py

@@ -2,6 +2,7 @@
 
 import contextlib
 
+from fastapi import FastAPI
 from opentelemetry import trace
 from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import OTLPSpanExporter
 from opentelemetry.instrumentation.fastapi import FastAPIInstrumentor
@@ -42,7 +43,7 @@ def configure_telemetry() -> None:
     trace.set_tracer_provider(provider)
 
 
-def instrument_app(app: "FastAPI") -> None:  # noqa: F821
+def instrument_app(app: FastAPI) -> None:
     """Instrument FastAPI and other libraries for tracing."""
     from src.lib.database import engine
 

apps/api/src/main.py

@@ -1,10 +1,10 @@
-from collections.abc import AsyncIterator
+from collections.abc import AsyncIterator, Awaitable, Callable
 from contextlib import asynccontextmanager
-from typing import Literal
+from typing import TYPE_CHECKING, Literal, cast
 from uuid import uuid4
 
 import structlog
-from fastapi import FastAPI, Request, status
+from fastapi import FastAPI, Request, Response, status
 from fastapi.middleware.cors import CORSMiddleware
 from fastapi.responses import JSONResponse
 from opentelemetry import trace
@@ -16,6 +16,9 @@
 from src.lib.logging import configure_logging, get_logger
 from src.lib.telemetry import configure_telemetry, instrument_app
 
+if TYPE_CHECKING:
+    import redis.asyncio as redis_module
+
 # Configure logging first
 configure_logging()
 logger = get_logger(__name__)
@@ -44,7 +47,9 @@ async def lifespan(app: FastAPI) -> AsyncIterator[None]:
 
 # Request ID middleware
 @app.middleware("http")
-async def request_id_middleware(request: Request, call_next):
+async def request_id_middleware(
+    request: Request, call_next: Callable[[Request], Awaitable[Response]]
+) -> Response:
     """Add request ID to each request for tracing."""
     request_id = request.headers.get("X-Request-ID", str(uuid4()))
 
@@ -164,8 +169,8 @@ async def check_redis() -> ServiceStatus | None:
     try:
         import redis.asyncio as redis
 
-        client = redis.from_url(settings.REDIS_URL)
-        await client.ping()
+        client = cast(redis_module.Redis, redis.from_url(settings.REDIS_URL))  # type: ignore[no-untyped-call]
+        await client.ping()  # type: ignore[misc]
         await client.aclose()
         latency = (time.perf_counter() - start) * 1000
         return ServiceStatus(status="healthy", latency_ms=round(latency, 2))

apps/mobile/mise.toml

@@ -1,6 +1,7 @@
 [tasks]
 dev = { run = "flutter run", description = "Run mobile app" }
 build = { run = "flutter build", description = "Build mobile app" }
+install = { run = "flutter pub get", description = "Install dependencies" }
 lint = { run = "flutter analyze", description = "Analyze mobile app" }
 format = { run = "dart format .", description = "Format mobile app" }
 test = { run = "flutter test", description = "Test mobile app" }